Start removing licenses(notice) and replacing with license()#742
Merged
aiuto merged 39 commits intobazelbuild:mainfrom Apr 16, 2024
Merged
Start removing licenses(notice) and replacing with license()#742aiuto merged 39 commits intobazelbuild:mainfrom
aiuto merged 39 commits intobazelbuild:mainfrom
Conversation
aiuto
changed the title
Collaborator
Author
|
@teeler - can we do this? |
Collaborator
Author
|
Lowered in urgency. It's going to make my imports harder if I do this today. |
Collaborator
Author
|
friendly ping from reviewers. |
Wyverald
approved these changes
Apr 16, 2024
cgrindel
approved these changes
Apr 16, 2024
Collaborator
Author
|
The failing test is unrelated to this. It is that --noenable_bzlmod does not work with bazel at head, and bazelci is ignoreing the explicit bazel version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
licenses()does not do anything.