Conversation
The cc toolchain autoconfig is out of sync from Bazel and doesn't work with VS2022. Related: bazelbuild/continuous-integration#1770
aiuto
reviewed
Nov 7, 2023
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
examples/rich_structure/WORKSPACE needs the same change.
But the centos build fails now. with
| gcc: error: unrecognized command line option '-std=c++14'
Did rules CC change in a way to believe it is always above 14?
Member
Author
Yes, with Bazel@HEAD, we already switch the default C++ standard to 14: bazelbuild/bazel#18280 We should switch to use centos7_java11_devtoolset10 or just drop this platform. |
aiuto
reviewed
Nov 7, 2023
Collaborator
|
Member
Author
Got it, added in back in |
aiuto
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cc toolchain autoconfig in rules_cc is out of sync from Bazel and doesn't work with VS2022.
Related: bazelbuild/continuous-integration#1770