Skip to content

CI fixes#784

Merged
aiuto merged 6 commits intobazelbuild:mainfrom
aiuto:ci
Nov 22, 2023
Merged

CI fixes#784
aiuto merged 6 commits intobazelbuild:mainfrom
aiuto:ci

Conversation

@aiuto
Copy link
Collaborator

@aiuto aiuto commented Nov 11, 2023

These are just to stop the spurious CI failures at head.
The right solution is to go back and have everything build uniformly with bzlmod or without it.

  • Get experimental git toolchain working enough with bzlmod so we can use it. But yeech. It really needs a bzlmod conversion. I would rather someone else build it.
  • Do not run the doc_build with bzlmod. It is impossible to have the sources work for both bzlmod and non_bzlmod because the module name changed. Or maybe it is, but I don't want to solve that right now.

@aiuto aiuto marked this pull request as ready for review November 11, 2023 05:30
@aiuto aiuto requested a review from alexeagle as a code owner November 11, 2023 05:30
@aiuto aiuto added the P1 An issue that must be resolved. Must have an assignee label Nov 22, 2023
@aiuto aiuto requested a review from meteorcloudy November 22, 2023 02:32
@aiuto aiuto merged commit dd4cb3c into bazelbuild:main Nov 22, 2023
@aiuto aiuto deleted the ci branch November 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 An issue that must be resolved. Must have an assignee

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants