Only inject pre and post scriptlets when provided#788
Merged
aiuto merged 2 commits intobazelbuild:mainfrom Nov 28, 2023
Merged
Conversation
Currently if the consumer doesn't provide a value for the pre or post scriplets we inject an empty scriptlet which has the effect of constructing an RPM that appears to have these scriplets (although they're empty). Instead, we likely want to not provide them at all in these cases.
aiuto
approved these changes
Nov 28, 2023
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
I'm going to presume this is reasonable behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the consumer doesn't provide a value for the pre or post scriplets we inject an empty scriptlet which has the effect of constructing an RPM that appears to have these scriplets (although they're empty). Instead, we likely want to not provide them at all in these cases.