Explicitly set %{_builddir} macro#792
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Dec 19, 2023
Merged
Conversation
rules_pkg has baked in the assumption that the value of `%{_builddir}`
is going to be `%{_topdir}/BUILD` which is where rpmbuild will `cd` to
when being run. When using the built in system rpmbuild in a
situation where the value of `%{_builddir}` has been overriden with a
custom local macro, this assumption may be broken which will result in
internal rpmbuild failures.
Because we make this assumption about the value of the macro, we can
instead be explicit about what we want the value of `%{_builddir}` to
be so as to avoid this problem altogether.
Collaborator
|
The failures are all stardoc. I"m going to force merge this and then disable the doc building in CI. |
Collaborator
|
Sigh... It/s not just stardoc. bzlmod at bazel 7.0.0. seems to mess with some things about local_repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_pkg has baked in the assumption that the value of
%{_builddir}is going to be%{_topdir}/BUILDwhich is where rpmbuild willcdto when being run. When using the built in system rpmbuild in a situation where the value of%{_builddir}has been overriden with a custom local macro, this assumption may be broken which will result in internal rpmbuild failures.Because we make this assumption about the value of the macro, we can instead be explicit about what we want the value of
%{_builddir}to be so as to avoid this problem altogether.