Add %posttrans scriptlet to RPM package#799
Merged
aiuto merged 2 commits intobazelbuild:mainfrom Dec 22, 2023
Merged
Conversation
Collaborator
cgrindel
reviewed
Dec 21, 2023
Collaborator
cgrindel
left a comment
cgrindel
left a comment
There was a problem hiding this comment.
Overall, LGTM. A couple of comments:
- I did not notice a test leveraging
postrans_scriptlet_file. Could you add one? - Could you update your branch with the latest to address the doc_build failures?
k0walik
force-pushed
the
rpm-posttrans-scriptlet
branch
from
7322067 to
209404a
Compare
Contributor
Author
Sure! I modified
Done |
aiuto
approved these changes
Dec 22, 2023
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
This looks like it should work.
Thanks for improving the testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPM package specification defines
%posttransscriptlet, which can be particularly useful when upgrading a package. We should add it to thepkg_rpmbuild rule.Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#ordering