Explicitly set the FILE bit in zip external attributes.#804
Merged
aiuto merged 2 commits intobazelbuild:mainfrom Jan 10, 2024
Merged
Explicitly set the FILE bit in zip external attributes.#804aiuto merged 2 commits intobazelbuild:mainfrom
aiuto merged 2 commits intobazelbuild:mainfrom
Conversation
This should not be needed, but it seems to be for some Azure users. Fixes bazelbuild#802
cgrindel
approved these changes
Jan 2, 2024
Collaborator
cgrindel
left a comment
cgrindel
left a comment
There was a problem hiding this comment.
Do we have any tests that can be augmented to check this?
Collaborator
Author
|
No. It seems to be Azure only. I need @romanofski to verify this does the right thing. |
aiuto
commented
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be needed, but it seems to be for some Azure users.
Fixes #802