Apply tar remap_paths to runfiles full paths#812
Merged
cgrindel merged 2 commits intobazelbuild:mainfrom Feb 1, 2024
Merged
Conversation
Collaborator
|
@aiuto This looks reasonable to me. I noticed that you started a dialogue with the author. Perhaps you should review it. |
cgrindel
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the way
remap_pathsworks onpkg_tarwhen usinginclude_runfilesso that remapping is performed on the full path of each runfile, instead of just in the base folder (foo.runfiles)This should be backwards compatible with the current behavior, and only affect those that specify runfiles paths in their mappings. For example, for the following path
foo.runfiles/some/folder/file.txt:I have implemented some tests that demonstrate this behaviors.
Resolves #790