pkg_install: Support TreeArtifacts.#885
Merged
aiuto merged 3 commits intobazelbuild:mainfrom Aug 28, 2024
Merged
Conversation
aiuto
reviewed
Aug 20, 2024
They are so confusing; I would've thought that because they took the parameters, they would set the user/group for me. But in fact, _chown_chmod needs to be called afterwards.
Implementation notes: For tree artifacts, when creating directories, we mostly follow the modes set for the whole TreeArtifact, but also +x to allow searching the directory. This is similar to how pkg_tar etc. handles things. Link: bazelbuild#308
Contributor
Author
|
I did a few changes:
As such, I did a force push for a fresh review. Please take a look; thanks! I didn't handle symlinks within the tree artifact, though. |
Contributor
Author
|
Hello, any updates? Could you please take a look at this pull request? Thanks! |
aiuto
approved these changes
Aug 28, 2024
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
Thanks for fixing this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation notes:
For tree artifacts, when creating directories, we mostly follow the modes set for the whole TreeArtifact, but also +x to allow searching the directory. This is similar to how pkg_tar etc. handles things.
Link: #308