pkg_install: modify log levels & print destdir by default.#891
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Sep 16, 2024
Merged
pkg_install: modify log levels & print destdir by default.#891aiuto merged 1 commit intobazelbuild:mainfrom
aiuto merged 1 commit intobazelbuild:mainfrom
Conversation
After this change, log levels are defined by the following:
* -q: only print errors (not even warnings)
* (default): print errors, warnings, infos
* -v: print above & also debug logs.
There are no errors and warnings logs at this moment.
The existing verbose logs about file operations are
categorized as debug logs, so they are only printed
when -v is set.
By default (if no flag is set), the destdir is printed
as an INFO level log.
Also improve the logging format to be similar to bazel's output, e.g.
INFO: Installing to /tmp/inst
Fixes bazelbuild#889
Contributor
Author
I missed that there are some critical logs. However this change does not change when critical logs are printed (they are always printed). |
aiuto
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change, log levels are defined by the following:
There are no errors and warnings logs at this moment. The existing verbose logs about file operations are categorized as debug logs, so they are only printed when -v is set.
By default (if no flag is set), the destdir is printed as an INFO level log.
Also improve the logging format to be similar to bazel's output, e.g.
Fixes #889