Skip to content

Modify the rich_structure example to set include_runfiles#906

Merged
aiuto merged 2 commits intobazelbuild:mainfrom
pcc:include_runfiles
Mar 6, 2025
Merged

Modify the rich_structure example to set include_runfiles#906
aiuto merged 2 commits intobazelbuild:mainfrom
pcc:include_runfiles

Conversation

@pcc
Copy link
Contributor

@pcc pcc commented Dec 19, 2024

Without this, the runfiles will not be packaged which is against the intent of this example which is to show how to package runfiles.

@pcc pcc requested review from aiuto and cgrindel as code owners December 19, 2024 21:00
@tonyaiuto
Copy link
Collaborator

Can you add a description of why this is needed in the description?
And, you need to sign the CLA.

@aiuto
Copy link
Collaborator

aiuto commented Feb 21, 2025

Friendly ping on description.

@pcc
Copy link
Contributor Author

pcc commented Feb 21, 2025

I'm a Google employee so not sure why it thinks I need to sign CLA.

@aiuto
Copy link
Collaborator

aiuto commented Mar 3, 2025

Can you merge to head and repush. I would like to see the tests run again now that we fixed CI.

@pcc pcc force-pushed the include_runfiles branch from 6a121c8 to f7e6409 Compare March 5, 2025 23:52
@pcc
Copy link
Contributor Author

pcc commented Mar 5, 2025

Can you merge to head and repush. I would like to see the tests run again now that we fixed CI.

Done

@aiuto aiuto merged commit cd7e108 into bazelbuild:main Mar 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants