Fix check_must_contain_regex in verify_archive.bzl#910
Merged
aiuto merged 2 commits intobazelbuild:mainfrom Jan 13, 2025
Merged
Fix check_must_contain_regex in verify_archive.bzl#910aiuto merged 2 commits intobazelbuild:mainfrom
aiuto merged 2 commits intobazelbuild:mainfrom
Conversation
Contributor
Author
|
Regarding red CI: it looks like |
Contributor
Author
|
I couldn't add any 'negative' tests to verify that But I can confirm that at my company this PR did the trick. |
cgrindel
approved these changes
Jan 9, 2025
tonyaiuto
approved these changes
Jan 13, 2025
aiuto
approved these changes
Jan 13, 2025
aiuto
added a commit
to aiuto/rules_pkg
that referenced
this pull request
Jan 13, 2025
The test was incorrect, but was passing becuase the test harness was broken. pr/910 fixed the harness, but did not follow up and fix the broken tests.
meteorcloudy
added a commit
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #909