Merged
Conversation
nicbadiu
force-pushed
the
patch-3
branch
2 times, most recently
from
15732c6 to
4ea728f
Compare
Collaborator
kellyma2
reviewed
Apr 11, 2025
nicbadiu
force-pushed
the
patch-3
branch
3 times, most recently
from
440204a to
4904055
Compare
This change enables the override of the auto-detected `/etc/os-release`-based `debuginfo` type and allows the auto-detection by means of a new `default` option. This also enables the use of `none` as an override option.
Contributor
Author
The description should be more targeted now. The docs are updated - which were behind other changes it seems. |
tonyaiuto
approved these changes
Jul 29, 2025
Collaborator
|
phooey. windows tests failing for no apparent reason. Have to look later. |
Collaborator
|
It looks like you did this instead of I patch the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the override of the auto-detected
/etc/os-release-baseddebuginfo_typeattribute of thebuild_repo_for_rpmbuild_toolchainrepository rule and allows the auto-detection by means of a newdefaultoption.This also enables the use of
noneas an override option.This change also includes a regeneration of the documentation, which seems to have trailed recent code changes. But there are no documentation changes related to this change as
build_repo_for_rpmbuild_toolchainrepository rule is not documented (yet).