Conditionally preserve file permissions when archiving through pkg_tar#951
Merged
aiuto merged 11 commits intobazelbuild:mainfrom Apr 30, 2025
Merged
Conditionally preserve file permissions when archiving through pkg_tar#951aiuto merged 11 commits intobazelbuild:mainfrom
aiuto merged 11 commits intobazelbuild:mainfrom
Conversation
added 8 commits
April 22, 2025 22:08
cgrindel
approved these changes
Apr 28, 2025
Collaborator
cgrindel
left a comment
cgrindel
left a comment
There was a problem hiding this comment.
Other than a code suggestion, LGTM.
Co-authored-by: Chuck Grindel <[email protected]>
aiuto
approved these changes
Apr 29, 2025
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
I'm rerunning CI in the hope it passes this time.
Collaborator
|
Can you run buildifier on the code. |
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the new
preserve_modeflag is enabled, set mode by extracting the permission bits from the file's mode attribute. Thepreserve_modeflag is disabled by default.This is related to Issue bazelbuild/bazel#2925.
This is based on bazelbuild/bazel#3585, except this work hides the feature under a disabled flag, to avoid changing the default behavior.
The feature was tested successfully on Linux and MacOS.