Convert the compression level to a string before calling Args.add()#975
Merged
cgrindel merged 1 commit intobazelbuild:mainfrom Sep 10, 2025
Merged
Conversation
The documentation for Bazel's Args states that standard conversion rules are only specified for strings, Files, and Labels. For all other types the conversion to a string is done in an unspecified manner, which is why it should be avoided. Let's stay away from this unspecified behaviour by explicitly converting the compression level to a string before calling Args.add().
EdSchouten
force-pushed
the
eschouten/20250909-str
branch
from
a71c3c1 to
b11e021
Compare
cgrindel
approved these changes
Sep 10, 2025
aiuto
pushed a commit
to aiuto/rules_pkg
that referenced
this pull request
Sep 11, 2025
…azelbuild#975) The documentation for Bazel's Args states that standard conversion rules are only specified for strings, Files, and Labels. For all other types the conversion to a string is done in an unspecified manner, which is why it should be avoided. Let's stay away from this unspecified behaviour by explicitly converting the compression level to a string before calling Args.add().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for Bazel's Args states that standard conversion rules are only specified for strings, Files, and Labels. For all other types the conversion to a string is done in an unspecified manner, which is why it should be avoided.
Let's stay away from this unspecified behaviour by explicitly converting the compression level to a string before calling Args.add().