Allow for variables in the package name of pkg_deb#985
Merged
aiuto merged 9 commits intobazelbuild:mainfrom Nov 21, 2025
Merged
Allow for variables in the package name of pkg_deb#985aiuto merged 9 commits intobazelbuild:mainfrom
aiuto merged 9 commits intobazelbuild:mainfrom
Conversation
Use Common Attributes also in the package name.
AtoZdevelopment
requested review from
aiuto and
dannysullivan
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Can you rebase on head and try again. |
On Windows, `pkg_install` wouldn't work out of the box without passing
`--enable_runfiles` to Bazel:
```
windows> bazel run [redacted]//:install -- --destdir=d:\est
[...]
INFO: Running command line: [redacted]/install.exe <args omitted>
Traceback (most recent call last):
File "[redacted]\install_install_script.py", line 307, in <module>
sys.exit(main(sys.argv))
^^^^^^^^^^^^^^
File "[redacted]\install_install_script.py", line 299, in main
installer.include_manifest_path(f)
File "[redacted]\install_install_script.py", line 182, in include_manifest_path
with open(path, 'r') as fh:
^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '../[redacted]/install_install_script-install-manifest.json'
```
In order to accomodate the various use cases (`build`, `test` and `run`
actions; enabled and disabled runfiles), the present change proposes to
leverage `rules_python`'s "runfiles" lookup library:
https://rules-python.readthedocs.io/en/latest/api/py/runfiles/runfiles.runfiles.html
For good measure, the change also enables
`bazel test //tests/install/...` in CI for Windows.
This might close bazelbuild#387.
This reverts commit a71a69d.
AtoZdevelopment
requested review from
cgrindel and
meteorcloudy
as code owners
Use Common Attributes also in the package name.
aiuto
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Common Attributes also in the package name.