Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Kaniko-based image and arguments with BuildKit for container building.
- Replaces the Kaniko image with BuildKit.
- Updates the build arguments and command to use buildctl-daemonless.sh.
- Removes the environment variable configuration for Git credentials by embedding them in the Git URL.
Comments suppressed due to low confidence (2)
src/server/services/build.service.ts:122
- [nitpick] The removal of the environment variable assignment for Git credentials appears intentional with the new URL-based approach. Confirm that no downstream components rely on these environment variables for authentication.
if (app.gitUsername && app.gitToken) { ... } (removed block)
src/server/services/build.service.ts:67
- Embedding credentials directly into the Git URL may expose sensitive data in logs or error messages. Please ensure that logs or error reporting do not inadvertently leak these credentials.
let gitContextUrl = `${app.gitUrl!}#refs/heads/${app.gitBranch}${contextPaths.folderPath ? ':' + contextPaths.folderPath : ''}`;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr relates to #33