Skip to content

BIP380: make specs consistent about hardened indicators#1803

Merged
jonatack merged 1 commit intobitcoin:masterfrom
quapka:hardened-indicator
Jun 20, 2025
Merged

BIP380: make specs consistent about hardened indicators#1803
jonatack merged 1 commit intobitcoin:masterfrom
quapka:hardened-indicator

Conversation

@quapka
Copy link
Contributor

@quapka quapka commented Mar 27, 2025

Me and my students noticed a discrepancy in the test vectors and specification regarding the allowed characters denoting hardened nodes. The BIP380 specs allows all three h, ' and H, in particular the specs read:

In the above specification, the hardened indicator h may be replaced with alternative
hardened indicators of H or '.

However, the following is then an invalid test vectors:

[deadbeef/0H/0H/0H]0260b2003c386519fc9eadf2b5cf124dd8eea4c4e68d5e154050a9346ea98ce600

Thus, I've added new test vectors allowing H and removed the inconsistent one.

However, I am far from claiming that this is the correct way how to handle this. I've checked that people are using the H, but I got no (meaningful or relevant) hits when searching for the exact test vector. I didn't see the option to create issues, thus I've continued by proposing the, what seems to be, reasonable changes.

@jonatack jonatack added Proposed BIP modification Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified labels Mar 28, 2025
@jonatack jonatack changed the title Make specs consistent about hardened indicators BIP380: make specs consistent about hardened indicators Mar 28, 2025
@murchandamus
Copy link
Member

cc: @achow101

@achow101
Copy link
Member

ACK 3d7ff96

@jonatack jonatack removed the Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified label Jun 20, 2025
@jonatack jonatack merged commit e22eaa5 into bitcoin:master Jun 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants