BIP172: Define Bitcoin Subunits as Satoshis#1841
Conversation
murchandamus
left a comment
There was a problem hiding this comment.
Thanks @0ceanSlim for your proposal. I don’t think I saw discussion about this on the mailing list, did you post it there? This looks fairly complete already, I just have a few formatting suggestions. Note that the "Created" header in the preamble refers to the date that a proposal was assigned a number, so the current value should be "?".
|
@murchandamus I actually have a draft email written as I knew it was procedure but didn't have the right email on hand. If you could send me the right one I'll send it. |
|
I've addressed your feedback! Thank you for taking a look! |
|
You can find information on the BIP Process in BIP 2. The email address is [email protected]. |
hm... That's the email I sent to but I got a response back that it didn't go through from gmx... I'll try sending again. Perhaps it's because I'm not a part of the group and I don't know how to add my gmx to the group yet. I'll look into it. |
murchandamus
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround. Could you take another look at the formatting of the alternative approaches? Were those intended to be lists or whole sentences? Right now it feels like it’s a bit in between those.
|
awesome, committed changes. I think the email went out too. I added my gmx to the group and sent again and I didn't get a failure notice. |
|
oh missed your first comment. It's meant to be a list but each reason is a sentence. How would you suggest I format? |
|
I also added a section on how it's analogous to the traditional currency systems today in the rationale |
edilmedeiros
left a comment
There was a problem hiding this comment.
Maybe this will be out of scope for this proposal, but feels so related that I can't not mention it.
Unicode has standardised a Bitcoin symbol under code U+20BF: ₿
Plane 0: Basic Multilingual Plane
Unicode Block: Currency Symbols
Unicode Version: 16.0
Would be at least nice to have it mentioned since you are formally defining 1 bitcoin in term of satoshis.
Unfortunately, they didn't define a symbol for satoshis. Maybe this proposal helps to justify doing so in the future, even though I believe we don't have such a common currency symbol for satoshis.
While I have proposed a couple symbols myself in the past, I would like to second that it should probably remain out of scope for this proposal, as debates about a satoshi symbol tend to consume other topics and not converge. |
cryptoquick
left a comment
There was a problem hiding this comment.
Finally, a sensible BIP. I appreciate how you addressed Murch's feedback. You have my ACK.
|
I'm good with it now. Just waiting on more review and feedback! Thanks for all the comments so far. |
0ceanSlim
left a comment
There was a problem hiding this comment.
I've addressed all current feedback and made some minor changes.
|
Actually before proceeding I want to address this comment on the mailing list From Lucas André:
While this is a great suggestion I'm on the fence as to whether or not this makes the BIP too verbose. Please let me know your thoughts. Sorry I'm addressing this comment last minute! |
I don’t think this is too verbose, feel free to put it in. |
|
I'm sorry about all the bad commits... I can't seem to get the readme correct. Also, @murchandamus if you'd like to suggest how I should format the addition of information for users with assistive technologies, that would be great |
|
Alright Everyone. Take a look see! I've added Accessibility Considerations and fixed some small punctuation errors ht/ @macedogm |
|
I would not oppose merging as it is, but I don't think the assistive tech additions contribute to the proposal. They are quite general comments/recommendations that apply to the good design of all human interfaces, not only bitcoin-related. Although important, they dilute the main contribution which is formally defining bitcoin subunits. Sorry I didn't seem this earlier, the pace of change in this proposal is quite swifty. |
|
@edilmedeiros I shared this concern but asked earlier and @murchandamus said he didn't think it was too verbose and to go ahead and add it if I would like to. So I did. I'd love to see this merged ❤️ |
|
a very nit but some sections have a |
Good catch. I added a space line after each heading. It seemed other BIPs mostly have it this way. |
|
Regardless of any pending changes, I would kindly ask for this to be merged in it's current form as we are indeed starting to get very nit on suggestions. That is of course unless any reviewers have a big pending issue with it's current form. |
|
Sorry, the unrelated on-going community debate has taken a big chunk of my time in the past week. Another review of this proposal is on my todo list but may take another few days. |
murchandamus
left a comment
There was a problem hiding this comment.
I have no further review comments. LGTM
269746e to
c379271
Compare
Formally define the smallest subunit of a bitcoin as a "Satoshi"