390: clarifications on KEY expression restrictions#1871
390: clarifications on KEY expression restrictions#1871jonatack merged 2 commits intobitcoin:masterfrom
Conversation
All of BIPs describing new descriptors require BIP 380
achow101
force-pushed
the
desc-clarifications
branch
from
6dea471 to
23e78b6
Compare
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Thanks, looks good to me.
| Type: Informational | ||
| Created: 2022-07-26 | ||
| License: BSD-2-Clause | ||
| Requires: 380 |
There was a problem hiding this comment.
Checked that 388 (omitted from this change) does not also require 380
achow101
force-pushed
the
desc-clarifications
branch
from
23e78b6 to
c754a4d
Compare
rkrux
left a comment
rkrux
left a comment
There was a problem hiding this comment.
The new verbiage is better and mostly not confusing - asked one question.
| the derivation path to be used when deriving from the aggregate public key. <tt>/*</tt> is also | ||
| optional. As there is no aggregate private key, only unhardened derivation from the aggregate public |
There was a problem hiding this comment.
/* is also
optional.
So musig(xpub.../1,xpub.../2)/3/4 will be treated as musig(xpub.../1,xpub.../2)/3/4/*?
If yes, I understand it's being provided to reduce verbosity but one with an explicit /* at the end would get rid of any possibility of a doubt in the mind of a reader imho.
There was a problem hiding this comment.
So musig(xpub.../1,xpub.../2)/3/4 will be treated as musig(xpub.../1,xpub.../2)/3/4/*?
On second thought, I think this is not what this means, they both will be treated separately.
Sorry I didn't mean to add more confusion.
|
ACK c754a4d |
4 participants
Clarifies the restrictions on KEY expressions around when child derivation is allowed.
Also added a
Requiresheader to all of the descriptor BIPs since they require reading 380 first.