bip373: add hyperlinks to other BIPs#1886
bip373: add hyperlinks to other BIPs#1886murchandamus merged 5 commits intobitcoin:masterfrom wedjob0X:master
Conversation
bip-0373.mediawiki
Outdated
| ===Motivation=== | ||
|
|
||
| BIP 327 specifies a way to create BIP 340 compatible public keys and signatures using the MuSig2 | ||
| [[bip-0327.mediawiki|BIP-327]] specifies a way to create BIP 340 compatible public keys and signatures using the MuSig2 |
There was a problem hiding this comment.
Hi @GuroChil, a few questions:
- why omit the first use of "BIP 327" on lines 18-19 (and would that first one suffice)
- why only for BIP 327
- why change the format from "BIP 327" to "BIP-327", when the non-hyphenated version was chosen by the author of this BIP
There was a problem hiding this comment.
Thanks for the detailed review! I've addressed all points:
Added the first BIP 327 reference on lines 18-19
Applied consistent formatting across other BIPs as well
Reverted back to non-hyphenated format as per original author's style
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Please update all the edits to undo the unnecessary sentence shifts due to changing where the lines break.
bip-0373.mediawiki
Outdated
| This document proposes additional fields for [[bip-0174.mediawiki|BIP 174]] PSBTv0 and [[bip-0370.mediawiki|BIP 370]] | ||
| PSBTv2 that allow for [[bip-0327.mediawiki|BIP 327]] MuSig2 Multi-Signature data to be included in a PSBT of any version. | ||
| These will be fields for the participants' keys, the public nonces, and the partial signatures produced with MuSig2. |
There was a problem hiding this comment.
Please don’t change where the lines break in the sentence when you are only editing single words. Instead leave the line breaks where they are and allow longer lines to minimize visual clutter in the diff.
| This document proposes additional fields for [[bip-0174.mediawiki|BIP 174]] PSBTv0 and [[bip-0370.mediawiki|BIP 370]] | |
| PSBTv2 that allow for [[bip-0327.mediawiki|BIP 327]] MuSig2 Multi-Signature data to be included in a PSBT of any version. | |
| These will be fields for the participants' keys, the public nonces, and the partial signatures produced with MuSig2. | |
| This document proposes additional fields for [[bip-0174.mediawiki|BIP 174]] PSBTv0 and [[bip-0370.mediawiki|BIP 370]] PSBTv2 that allow for | |
| [[bip-0327.mediawiki|BIP 327]] MuSig2 Multi-Signature data to be included in a PSBT of any version. These will be fields for | |
| the participants' keys, the public nonces, and the partial signatures produced with MuSig2. |
bip-0373.mediawiki
Outdated
| nonce that is added in a <tt>PSBT_IN_MUSIG2_PUB_NONCE</tt> field. However | ||
| signers must keep in mind that '''improper nonce usage can compromise private | ||
| keys.''' Please see BIP 327 for best practices on nonce generation and usage. | ||
| keys.''' Please see [[bip-0327.mediawiki|BIP-327]] for best practices on nonce generation and usage. |
There was a problem hiding this comment.
Nit: Please drop the dash for consistency.
There was a problem hiding this comment.
Thank you for the feedback!
I've implemented all the suggested changes. Please let me know if you have any other recommendations.
I've implemented all the suggested changes
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Maybe I was unclear, but you overlooked a few.
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Fixed it myself to spend less time on this.
murchandamus
changed the title
3 participants
add hyperlinks to BIPs 327