380: Disallow H as a hardened indicator#1888
Merged
murchandamus merged 1 commit intobitcoin:masterfrom Jul 3, 2025
Merged
Conversation
Member
|
Concept ACK. ACK 3cc71d7 |
rkrux
reviewed
Jul 3, 2025
Contributor
rkrux
left a comment
rkrux
left a comment
There was a problem hiding this comment.
ACK 3cc71d7
I asked about this on the mailing list last week and have received no responses. There was also some discussion in bitcoin/bitcoin#32788.
This question was mentioned in Optech Newsletter 360 also.
murchandamus
reviewed
Jul 3, 2025
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
LGTM. Did you want to go ahead or do you want to wait a bit longer?
Member
Author
|
I think we can go ahead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that there are few/no software that produce descriptors using
H, while few accept it during parsing. As neither of the reference implementations of Bitcoin Core nor rust-miniscript supportHat all, it seems to be better to removeHas a hardened indicator from the BIP rather than updating all of the existing software.I asked about this on the mailing list last week and have received no responses. There was also some discussion in bitcoin/bitcoin#32788.