BIP111: update status from Proposed to Final#1956
Conversation
|
cc BIP authors @TheBlueMatt and @petertodd |
|
Is there a Rescinded status given that its now off-by-default and really shouldn't be used? |
murchandamus
left a comment
There was a problem hiding this comment.
ACK
Per BIP 2, Withdrawn only follows from Draft, where I would argue here that this BIP should have long been Final. From Final something would only be updated to Replaced or Obsolete. In this case, I think that some Bitcoin implementations still serve BIP 37 and previously it was argued that BIP 37 should remain in Final for that reason, so perhaps the same applies here.
TheBlueMatt
left a comment
There was a problem hiding this comment.
Sure, LGTM. Whatever status y'all think makes the most sense.
|
Obsolete makes sense to me. The replacement for bloom filters is compact block
filters, which does ~everything they did but better.
|
|
Thanks all for the feedback.
Given these, (for now) it seems that BIP111 should be Final. At some point, perhaps when support is removed, they can be marked as Replaced or Obsolete and the BIP 152 header updated to indicate that it replaces them. |
murchandamus
left a comment
There was a problem hiding this comment.
I think "Final" is correct for the time being.
The
NODE_BLOOMservice bit has been deployed in Bitcoin Core since bitcoin/bitcoin#6579.