bip155: mark torv2 as no longer in use#1975
Conversation
e4fd7c3 to
2f20155
Compare
|
Pinging BIP author @laanwj for feedback or approval. Not sure if Appendix A about Tor v2 address encoding should be removed or kept for historical context. |
|
Perhaps a Changelog would be useful here. |
Or maybe we could keep it for historical context but change the title to |
|
Maybe |
2f20155 to
278aa42
Compare
bip-0155.mediawiki
Outdated
| | <code>TORV2</code> | ||
| | 10 | ||
| | Tor v2 hidden service address | ||
| | Tor v2 hidden service address (**Tor v2 is no longer operational**; clients **MUST NOT** gossip or relay Tor v2 addresses and **MUST** ignore them on receive). |
There was a problem hiding this comment.
It doesn't look like ** works (the idea was to make bold text, i guess?) in the rendered version. https://github.com/bitcoin/bips/blob/278aa42bdca2824d0e42fbfa4a7167955b08aaf1/bip-0155.mediawiki
Also i wonder if this wouldn't better be moved to a footnote, instead of having the entire text in the table
E.g. Tor v2 hidden service address (no longer used [1])
[1] Tor v2 is no longer operational; clients MUST NOT gossip or relay Tor v2 addresses and MUST ignore them on receive
|
Concept obvious ACK |
42fb375 to
31158ef
Compare
|
Just moved the text into a footnote (I just noted that some BIPs calls the section that refers to CI failure seems unrelated: |
bip-0155.mediawiki
Outdated
| | <code>TORV2</code> | ||
| | 10 | ||
| | Tor v2 hidden service address | ||
| | Tor v2 hidden service address (no longer used<ref>Tor v2 is no longer operational; clients MUST NOT gossip or relay Tor v2 addresses and MUST ignore them on receive</ref>) |
There was a problem hiding this comment.
Agree that this information was too long for the table and is better as a footnote.
Should Appendix A also be updated with that info? Seems odd to leave it as-is and have it be contradicted elsewhere in a footnote. What do you think?
There was a problem hiding this comment.
I agree it's odd to leave the Appendix A as is. We could point out there to the same <ref> we introduced before.
31158ef to
0035953
Compare
cc0db2e to
7fd375c
Compare
TorV2 is deprecated, implementations are removing any support for it and we could specify this deprecation here. Especially because implementations are no longer serializing/deserializing and relaying Tor v2 addresses, they're ignoring incoming Tor v2 addresses, etc.