BIP321: add reference implementation, mention BIP21 replacement#1983
Merged
murchandamus merged 2 commits intobitcoin:masterfrom Oct 1, 2025
Merged
Conversation
Member
jonatack
commented
Sep 24, 2025
jonatack
commented
- Add Reference Implementation section, using the BIP author's suggested implementation in Mark BIP21 as replaced by 321, update 321 from Draft to Proposed #1911 (comment)
- Mention replacement in addition to modification with respect to BIP21, for consistency with the "Replaces: 21" header
murchandamus
added
the
Pending acceptance
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
@TheBlueMatt, could you please take a look and sign-off on these two links being the intended content of the Reference Implementation section?
TheBlueMatt
reviewed
Sep 30, 2025
Contributor
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
LGTM, modulo murch's style note
rather than only modification, for consistency with the "Replaces: 21" header
jonatack
force-pushed
the
2025-09-BIP321-add-reference-implementation
branch
from
c4acb08 to
c16a336
Compare
Member
Author
|
Thanks @murchandamus and @TheBlueMatt. Updated to take the feedback. |
murchandamus
reviewed
Oct 1, 2025
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
ACK, and signed off by Author.
murchandamus
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.