bip-373: Fix GLOBAL_XPUB key name and clean up compressed vs x-only note#2007
Merged
murchandamus merged 2 commits intobitcoin:masterfrom Dec 9, 2025
Merged
Conversation
jonatack
reviewed
Oct 17, 2025
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK, nice fixups. Maybe optionally add this while here.
--- a/bip-0373.mediawiki
+++ b/bip-0373.mediawiki
@@ -9,13 +9,14 @@
Type: Standards Track
Created: 2024-06-04
License: CC0-1.0
+ Requires: 32, 174, 327, 328, 370
</pre>
Member
|
ACK d175b46 |
Contributor
Author
Oh, forgot about it, added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced incorrect PSBT key name PSBT_IN_GLOBAL_XPUB with the canonical PSBT_GLOBAL_XPUB (per BIP 174). This corrects scope naming (GLOBAL vs per-input) and aligns with existing PSBT specifications.
Removed duplicated/garbled sentence and punctuation in the reference note explaining why compressed pubkeys are used instead of x-only. The note now clearly states the evenness-byte requirement and fingerprint rationale without repetition.