BIP-374: Pass G and m to VerifyProof in GenerateProof self-check#2011
Merged
jonatack merged 1 commit intobitcoin:masterfrom Oct 23, 2025
Merged
BIP-374: Pass G and m to VerifyProof in GenerateProof self-check#2011jonatack merged 1 commit intobitcoin:masterfrom
jonatack merged 1 commit intobitcoin:masterfrom
Conversation
jonatack
reviewed
Oct 21, 2025
Member
|
cc: @andrewtoth |
andrewtoth
approved these changes
Oct 23, 2025
Contributor
andrewtoth
left a comment
There was a problem hiding this comment.
ACK 1bb1aee
Nice catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: In GenerateProof step 85 the self-check calls VerifyProof(A, B, C, proof) without G and m, but VerifyProof is defined as VerifyProof(A, B, C, proof, G, m). This omission breaks self-check when a non-empty message m is used or when a non-default generator G is passed.
Evidence:
Spec definition requires G and m:
Reference implementation passes G and m in the self-check:
bip-0374/reference.py
GenerateProof includes m in challenge derivation and treats G as an input, so omitting them in VerifyProof recomputes a different challenge and will fail for non-empty m and non-default G.