BIP-310: fix version-rolling.min-bit-count parameter spec#2065
Merged
jonatack merged 1 commit intobitcoin:masterfrom Feb 28, 2026
Merged
Conversation
murchandamus
added
Pending acceptance
Member
|
@janbraiins, Pavel: Is this correct and substantial enough to merge? |
Contributor
|
Yes, this is correct and can be merged in my view |
jonatack
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version-rolling.min-bit-count field was previously documented as a TMask return value, even though the examples and real-world usage treat it as a request parameter with an integer bit count.
This change moves version-rolling.min-bit-count to the extension parameters section and changes its type to Integer (>= 0), keeping the original explanatory text. This makes the specification consistent with the JSON examples and with existing implementations of the stratum protocol extension.