Fix shadowing of 'what' as described in #10080.#10089
Closed
dooglus wants to merge 1 commit intobitcoin:masterfrom
Closed
Fix shadowing of 'what' as described in #10080.#10089dooglus wants to merge 1 commit intobitcoin:masterfrom
dooglus wants to merge 1 commit intobitcoin:masterfrom
Conversation
Member
|
Duplicate of #10087. |
Contributor
|
Closing mine, as @dooglus was original reporter. Thanks! |
Contributor
|
ACK c8b6cc7 |
Contributor
Author
|
I'm seeing a lot of very similar warnings when building the Qt client: I don't remember seeing them previously (like on the 0.14 branch). What is causing all this 'shadowing' all of a sudden? |
Contributor
|
We turned on |
Contributor
Author
|
Well that explains it then! I'm happy to fix these warnings if there's an acceptable way of coming up with alternative non-shadowing argument names. You didn't like my underscore, and I don't know how you came up with your suggested replacement name. |
Contributor
Member
Yes, ever since enabling them (and before that) there has been a huge discussion about this. See also my comment here: #9911 (comment) Unlike in C, for C++ the concept of shadowing seems to be somewhat subjective per compiler vendor and version. So if the source code is clear in clang, it may still cough up tons of warnings in g++. Older versions of g++ tend to go over the top to emit as many warnings as possible. We cannot and should not fix all shadowing warnings for all compilers. Maybe it would make sense to disable the warning for some older gccs. |
Member
|
NACK. Let's disable wshadow on oder gcc versions. |
Member
|
Closing this. Let's continue discussion about disabling -wshadow / fixing older versions in #10080. |
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Apr 1, 2017
This warning was enabled by default in bitcoin#8808 but it's a [continuing](bitcoin#9911 (comment)) [source](bitcoin#10089 (comment)) of [annoyance](bitcoin#9911 (comment)) for me and other developers. I'm sick of sounding like a broken record, so disable it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@paveljanik is this what you meant? I didn't really understand your request.