Conversation
|
ACK 47d8441 Very good! Thanks for clarifying! |
| - Global variables have a `g_` prefix. | ||
| - Constant names are all uppercase, and use `_` to separate words. | ||
| - Class names, function names and method names are CamelCase. Do not prefix | ||
| class names with `C`. |
There was a problem hiding this comment.
Why not prefix class names with C?
|
It is always obvious from the usage that a name refers to a class and not a function/method, so no need to repeat that information in the name. |
|
Is it? |
|
Seems fine to me. |
| - Class member variables have a `m_` prefix. | ||
| - Global variables have a `g_` prefix. | ||
| - Constant names are all uppercase, and use `_` to separate words. | ||
| - Class names, function names and method names are CamelCase. Do not prefix |
There was a problem hiding this comment.
Not sure if we had a discussion about that already:
I often saw projects where the static class methods and global space functions where in UpperCamelCase() while the class methods where in lowerCamelCase() and I think this is useful.
But no strong opinion.
There was a problem hiding this comment.
Except for the qt code, this just documents the style already in use.
So while this sounds sensible for a new project, I don't think we should change this now.
|
ACK 47d8441 |
| style over attempting to mimick the surrounding style, except for move-only | ||
| commits. | ||
|
|
||
| Do not submit patches solely to modify the style of existing code. |
There was a problem hiding this comment.
Thanks for adding this explicitly 👍
|
utACK 47d8441 |
47d8441 Update style guide (Pieter Wuille) Tree-SHA512: 0b11365f294eeda1ea5c45cf04b3f38435602f61edc0c605e067ed9d17d17c28e9f1dd76bd4fa8a630e9cec8c5103cd2bfe5f6097196761d576913d9180f2ecf
|
ACK |
47d8441 Update style guide (Pieter Wuille) Tree-SHA512: 0b11365f294eeda1ea5c45cf04b3f38435602f61edc0c605e067ed9d17d17c28e9f1dd76bd4fa8a630e9cec8c5103cd2bfe5f6097196761d576913d9180f2ecf
47d8441 Update style guide (Pieter Wuille) Tree-SHA512: 0b11365f294eeda1ea5c45cf04b3f38435602f61edc0c605e067ed9d17d17c28e9f1dd76bd4fa8a630e9cec8c5103cd2bfe5f6097196761d576913d9180f2ecf
47d8441 Update style guide (Pieter Wuille) Tree-SHA512: 0b11365f294eeda1ea5c45cf04b3f38435602f61edc0c605e067ed9d17d17c28e9f1dd76bd4fa8a630e9cec8c5103cd2bfe5f6097196761d576913d9180f2ecf
10 participants
As discussed in this week's IRC meeting.