Skip to content

Names: BIP9 vs versionbits#10463

Merged
laanwj merged 2 commits intobitcoin:masterfrom
jtimon:b15-bip8-cherry-reanme
Jun 6, 2017
Merged

Names: BIP9 vs versionbits#10463
laanwj merged 2 commits intobitcoin:masterfrom
jtimon:b15-bip8-cherry-reanme

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented May 27, 2017 •
edited
Loading

Whether bip8 it's adopted or not it seems clear bip9 was flawed in its assumptions, the version bit part was right and will be continued by proposed extensions.

This should be orthogonal to #10462, but maybe it helps in review before or after and it's better documentation long term.

@shaolinfry
Copy link
Contributor

shaolinfry commented May 27, 2017

Can someone restart the two failed jobs, they look like random Travis related fails.

@fanquake
Copy link
Member

fanquake commented May 27, 2017 •
edited
Loading

Restarted both jobs. For reference the errors were:

stdout:
2017-05-27 01:32:40.308000 TestFramework (INFO): Initializing test directory /tmp/bitcoin_test_runner_20170527_013135/p2p-compactblocks_160
2017-05-27 01:32:40.564000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 281, in start_nodes
    rpcs.append(start_node(i, dirname, extra_args[i], rpchost, timewait=timewait, binary=binary[i]))
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 242, in start_node
    wait_for_bitcoind_start(bitcoind_processes[i], url, i)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 216, in wait_for_bitcoind_start
    raise Exception('bitcoind exited with status %i during initialization' % process.returncode)
Exception: bitcoind exited with status 1 during initialization
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 146, in main
    self.setup_network()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 81, in setup_network
    self.setup_nodes()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 94, in setup_nodes
    self.nodes = start_nodes(self.num_nodes, self.options.tmpdir, extra_args)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 283, in start_nodes
    stop_nodes(rpcs)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 303, in stop_nodes
    assert not bitcoind_processes.values() # All connections must be gone now
AssertionError
2017-05-27 01:32:40.565000 TestFramework (INFO): Stopping nodes
stderr:
************************
EXCEPTION: St12out_of_range       
map::at       
bitcoin in AppInit()       
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/p2p-compactblocks.py", line 945, in <module>
    CompactBlocksTest().main()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 162, in main
    self.stop_nodes()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 206, in stop_nodes
    stop_nodes(self.nodes)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 301, in stop_nodes
    for i, node in enumerate(nodes):
TypeError: 'NoneType' object is not iterable
.......................................................
p2p-segwit.py failed, Duration: 5 s
stdout:
2017-05-27 01:33:04.891000 TestFramework (INFO): Initializing test directory /tmp/bitcoin_test_runner_20170527_013135/p2p-segwit_156
2017-05-27 01:33:10.047000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 281, in start_nodes
    rpcs.append(start_node(i, dirname, extra_args[i], rpchost, timewait=timewait, binary=binary[i]))
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 242, in start_node
    wait_for_bitcoind_start(bitcoind_processes[i], url, i)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 216, in wait_for_bitcoind_start
    raise Exception('bitcoind exited with status %i during initialization' % process.returncode)
Exception: bitcoind exited with status 1 during initialization
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 146, in main
    self.setup_network()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/p2p-segwit.py", line 120, in setup_network
    self.setup_nodes()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 94, in setup_nodes
    self.nodes = start_nodes(self.num_nodes, self.options.tmpdir, extra_args)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 283, in start_nodes
    stop_nodes(rpcs)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 303, in stop_nodes
    assert not bitcoind_processes.values() # All connections must be gone now
AssertionError
2017-05-27 01:33:10.048000 TestFramework (INFO): Stopping nodes
stderr:
************************
EXCEPTION: St12out_of_range       
map::at       
bitcoin in AppInit()       
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/p2p-segwit.py", line 1952, in <module>
    SegWitTest().main()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 162, in main
    self.stop_nodes()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 206, in stop_nodes
    stop_nodes(self.nodes)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/util.py", line 301, in stop_nodes
    for i, node in enumerate(nodes):
TypeError: 'NoneType' object is not iterable

shaolinfry and others added 2 commits May 30, 2017 19:21
@shaolinfry @jtimon
Rename -bip9params to -vbparams
29c0719
@jtimon
scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/
b463bc9 
-BEGIN VERIFY SCRIPT-
sed -i 's/BIP9DeploymentInfo/VBDeploymentInfo/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ;
-END VERIFY SCRIPT-
@jtimon jtimon force-pushed the b15-bip8-cherry-reanme branch from 23ce132 to b463bc9 Compare May 30, 2017 17:22
@jtimon
Copy link
Contributor Author

jtimon commented May 30, 2017

Sorry, the error was just one s/-bip9params/-vbparams/ lost in rebase, not a problem with travis. Updated.

@shaolinfry
Copy link
Contributor

shaolinfry commented May 31, 2017

@fanquake can you rerun Travis - looks like the VM errored and stopped the build process prematurely.

utACK assuming they pass.

@fanquake
Copy link
Member

fanquake commented May 31, 2017

@shaolinfry Restarted, looks like they are all passing now.

@shaolinfry
Copy link
Contributor

shaolinfry commented May 31, 2017

utACK b463bc9

@laanwj
Copy link
Member

laanwj commented Jun 1, 2017

Concept ACK, I think this naming is better because it is more general.

@benma
Copy link

benma commented Jun 1, 2017

utACK b463bc9

@instagibbs
Copy link
Member

instagibbs commented Jun 2, 2017

utACK b463bc9

@laanwj laanwj merged commit b463bc9 into bitcoin:master Jun 6, 2017
laanwj added a commit that referenced this pull request Jun 6, 2017
@laanwj
Merge #10463: Names: BIP9 vs versionbits
323a46e 
b463bc9 scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/ (Jorge Timón)
29c0719 Rename -bip9params to -vbparams (shaolinfry)

Tree-SHA512: a8a2bf6e24a4a7fc82f784c78c0cd92472e9ba55ce3fb22dafef3eccdcfccb2da5a6078fbeec1a8a4b6ab1f1b226976c5aba964dd5e3d029a21b109a7c044374
@jtimon jtimon deleted the b15-bip8-cherry-reanme branch June 14, 2017 04:24
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10463: Names: BIP9 vs versionbits
42985c3 
b463bc9 scripted-diff: s/BIP9DeploymentInfo/VBDeploymentInfo/ (Jorge Timón)
29c0719 Rename -bip9params to -vbparams (shaolinfry)

Tree-SHA512: a8a2bf6e24a4a7fc82f784c78c0cd92472e9ba55ce3fb22dafef3eccdcfccb2da5a6078fbeec1a8a4b6ab1f1b226976c5aba964dd5e3d029a21b109a7c044374
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jtimon @shaolinfry @fanquake @laanwj @benma @instagibbs