scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE#10502
Merged
sipa merged 4 commits intobitcoin:masterfrom Jun 14, 2017
Merged
scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE#10502sipa merged 4 commits intobitcoin:masterfrom
sipa merged 4 commits intobitcoin:masterfrom
Conversation
This was referenced Jun 1, 2017
Contributor
|
utACK 9eafbf2 Excellent work! I ❤️ modern C++ |
Contributor
Author
|
Added one small preparation commit since not all environments where passing travis. |
Contributor
Author
|
Needed rebase after #10195. Just run the sed scripts again. Review should be as simple as it was, more or less. |
-BEGIN VERIFY SCRIPT- sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
-BEGIN VERIFY SCRIPT- sed -i 's/Q_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
-BEGIN VERIFY SCRIPT- sed -i 's/PAIRTYPE(\([^,]*\), \([^\)]*\))/std::pair<\1, \2>/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; sed -i ':a;N;$!ba;s/#define std::pair<t1, t2> std::pair<t1, t2>\n//' ./src/utilstrencodings.h ; -END VERIFY SCRIPT-
Contributor
Author
|
Needed rebase again(2) |
Member
|
Concept ACK. Nit: you can add a commit that removes the |
Contributor
Author
But not in the whole project yet, because I'm not able to remove BOOST_REVERSE_FOREACH yet, see #10193 on top of this one. I can remove it only on the files that I can for now. |
Member
|
nice, utACK 1238f13. |
sipa
added a commit
that referenced
this pull request
Jun 14, 2017
…TYPE 1238f13 scripted-diff: Remove PAIRTYPE (Jorge Timón) 18dc3c3 scripted-diff: Remove Q_FOREACH (Jorge Timón) 7c00c26 scripted-diff: Fully remove BOOST_FOREACH (Jorge Timón) a5410ac Small preparations for Q_FOREACH, PAIRTYPE and #include <boost/foreach.hpp> removal (Jorge Timón) Tree-SHA512: d3ab4a173366402e7dcef31608977b757d4aa07abbbad2ee1bcbcfa311e994a4552f24e5a55272cb22c2dcf89a4b0495e02e9d9aceae4b08c0bab668f20e324c
Member
|
utACK 1238f13 |
1 task
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 9, 2019
-BEGIN VERIFY SCRIPT- sed -i 's/BOOST_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 9, 2019
-BEGIN VERIFY SCRIPT- sed -i 's/Q_FOREACH *(\(.*\),/for (\1 :/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; -END VERIFY SCRIPT-
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 9, 2019
-BEGIN VERIFY SCRIPT- sed -i 's/PAIRTYPE(\([^,]*\), \([^\)]*\))/std::pair<\1, \2>/' ./src/*.h ./src/*.cpp ./src/*/*.h ./src/*/*.cpp ./src/*/*/*.h ./src/*/*/*.cpp ; sed -i ':a;N;$!ba;s/#define std::pair<t1, t2> std::pair<t1, t2>\n//' ./src/utilstrencodings.h ; -END VERIFY SCRIPT-
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Dec 4, 2020
Backport Boost removal PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7613 - bitcoin/bitcoin#10502 - bitcoin/bitcoin#10193 - bitcoin/bitcoin#13961 - bitcoin/bitcoin#13734 - Only the second commit (we don't need the first). - bitcoin/bitcoin#14480 Part of #4819.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated from #10193 since the reverse iterator isn't working there, as suggested in #10193 (comment) (but without removing #include <boost/foreach.hpp> everywhere except where BOOST_REVERSE_FOREACH is needed).
Seems to compete with #10497