Skip to content

Remove 33 unused Boost includes#10546

Merged
laanwj merged 1 commit intobitcoin:masterfrom
practicalswift:remove-unused-boost-includes
Jun 11, 2017
Merged

Remove 33 unused Boost includes#10546
laanwj merged 1 commit intobitcoin:masterfrom
practicalswift:remove-unused-boost-includes

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jun 7, 2017 •
edited
Loading

Remove 33 unused Boost includes.

@practicalswift practicalswift changed the title Remove unused Boost includes Remove 38 unused Boost includes Jun 7, 2017
fanquake
fanquake reviewed Jun 7, 2017
View reviewed changes
src/util.cpp Outdated
Copy link
Member

@fanquake fanquake Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starts_with() is still used.

Copy link
Contributor Author

@practicalswift practicalswift Jun 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed!

@practicalswift practicalswift force-pushed the remove-unused-boost-includes branch from d399e1b to d652c75 Compare June 7, 2017 10:04
@practicalswift practicalswift changed the title Remove 38 unused Boost includes Remove 37 unused Boost includes Jun 7, 2017
@paveljanik
Copy link
Contributor

paveljanik commented Jun 7, 2017 •
edited
Loading

compiles ACK d652c75

195 more #include <boost/.*> to go!

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jun 8, 2017 •
edited
Loading

Gitian builds this fine: https://bitcoin.jonasschnelli.ch/build/166
ACK d652c7515bbae6d51470cf5ee538b0d5cad9547f

@practicalswift practicalswift force-pushed the remove-unused-boost-includes branch from d652c75 to 5262723 Compare June 8, 2017 19:18
@practicalswift
Copy link
Contributor Author

practicalswift commented Jun 8, 2017

Merge conflicts resolved!

@practicalswift practicalswift force-pushed the remove-unused-boost-includes branch 4 times, most recently from 2218588 to d643345 Compare June 8, 2017 22:47
@practicalswift practicalswift changed the title Remove 37 unused Boost includes Remove 36 unused Boost includes Jun 8, 2017
@fanquake
Copy link
Member

fanquake commented Jun 9, 2017

Builds are failing with

  CXX      wallet/libbitcoin_wallet_a-feebumper.o
In file included from wallet/crypter.cpp:5:0:
wallet/crypter.h:195:5: error: ‘signals2’ in namespace ‘boost’ does not name a type
     boost::signals2::signal<void (CCryptoKeyStore* wallet)> NotifyStatusChanged;
     ^
wallet/crypter.cpp: In member function ‘bool CCryptoKeyStore::Lock()’:
wallet/crypter.cpp:167:29: error: ‘NotifyStatusChanged’ was not declared in this scope
     NotifyStatusChanged(this);
                             ^
wallet/crypter.cpp: In member function ‘bool CCryptoKeyStore::Unlock(const CKeyingMaterial&)’:
wallet/crypter.cpp:205:29: error: ‘NotifyStatusChanged’ was not declared in this scope
     NotifyStatusChanged(this);

@practicalswift practicalswift force-pushed the remove-unused-boost-includes branch 2 times, most recently from ecb1c4a to 16c3a98 Compare June 9, 2017 07:42
@practicalswift practicalswift force-pushed the remove-unused-boost-includes branch from 16c3a98 to 49de096 Compare June 9, 2017 08:25
@practicalswift practicalswift changed the title Remove 36 unused Boost includes Remove 33 unused Boost includes Jun 9, 2017
@practicalswift
Copy link
Contributor Author

practicalswift commented Jun 9, 2017

@fanquake Thanks for the notification. Builds now passing!

@fanquake
Copy link
Member

fanquake commented Jun 9, 2017

utACK 49de096

@sipa
Copy link
Member

sipa commented Jun 9, 2017

utACK 49de096

@laanwj laanwj merged commit 49de096 into bitcoin:master Jun 11, 2017
laanwj added a commit that referenced this pull request Jun 11, 2017
@laanwj
Merge #10546: Remove 33 unused Boost includes
2c2d988 
49de096 Remove unused Boost includes (practicalswift)

Tree-SHA512: ff2dad94f9eeb1dc50fcffd0e94e1686be04e4e5bc45f58ae955d630c15cd25bb8f5583d0aa1f2f263b5a723be79747ef3c6e6b417c7be7787c0abc8d1874019
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10546: Remove 33 unused Boost includes
1099c1a 
49de096 Remove unused Boost includes (practicalswift)

Tree-SHA512: ff2dad94f9eeb1dc50fcffd0e94e1686be04e4e5bc45f58ae955d630c15cd25bb8f5583d0aa1f2f263b5a723be79747ef3c6e6b417c7be7787c0abc8d1874019
@str4d str4d mentioned this pull request Oct 22, 2020
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Oct 26, 2020
@zkbot
Auto merge of #4805 - str4d:fs-abstraction, r=str4d
40d5f0a 
Lightweight abstraction of boost::filesystem

This is a refactor backport ahead of replacing most of our Boost dependencies with C++17 code.

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#7667
  - Removes merge conflicts.
- bitcoin/bitcoin#9902
- bitcoin/bitcoin@2300a5e
- bitcoin/bitcoin#10546
  - Only the changes to `src/fs.cpp`
@practicalswift practicalswift deleted the remove-unused-boost-includes branch April 10, 2021 19:31
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake left review comments

+1 more reviewer

@dcousens dcousens dcousens approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@practicalswift @paveljanik @jonasschnelli @fanquake @sipa @dcousens @laanwj