Skip to content

Remove unused constants#10560

Merged
laanwj merged 2 commits intobitcoin:masterfrom
practicalswift:noop-modes
Jun 11, 2017
Merged

Remove unused constants#10560
laanwj merged 2 commits intobitcoin:masterfrom
practicalswift:noop-modes

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jun 8, 2017 •
edited
Loading

  • Remove unused constant MEMPOOL_GD_VERSION
  • Comment out unused constant REJECT_DUST

@achow101
Copy link
Member

achow101 commented Jun 8, 2017

NACK -testsafemode is not unused. It is part of GetWarnings and will set a warning for strStatusBar, strRPC, and strGUI which will then trigger the safe mode handling of RPCs. Safe mode is still used in the RPCs to disable certain RPCs if safe mode is enabled.

@practicalswift
Copy link
Contributor Author

practicalswift commented Jun 8, 2017

@achow101 Ah, sorry. I missed that the safe mode logic in OnRPCPreCommand is triggered by strRPC != nullptr (via GetWarnings("rpc") :-) Thanks for clarifying. Reverting that part of this PR.

@practicalswift practicalswift changed the title Remove non-existing "force safe mode" (-testsafemode). Remove unused constants. Remove unused constants Jun 8, 2017
@practicalswift
Copy link
Contributor Author

practicalswift commented Jun 8, 2017

@achow101 Updated :-)

achow101
achow101 reviewed Jun 9, 2017
View reviewed changes
src/consensus/validation.h Outdated
Copy link
Member

@achow101 achow101 Jun 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is part of BIP 61, I think it should remain as is even though it is unused.

Copy link
Contributor Author

@practicalswift practicalswift Jun 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achow101 I intentionally left it commented out instead of removing it. By commenting it out we get rid of unused constant warnings until it is used :-)

@practicalswift
Copy link
Contributor Author

practicalswift commented Jun 9, 2017

@achow101 Thanks for reviewing! Added a comment about BIP 61. Looks good?

@sipa
Copy link
Member

sipa commented Jun 9, 2017

utACK dce8239

1 similar comment
@achow101
Copy link
Member

achow101 commented Jun 9, 2017

utACK dce8239

@fanquake
Copy link
Member

fanquake commented Jun 10, 2017

utACK dce8239

@laanwj laanwj merged commit dce8239 into bitcoin:master Jun 11, 2017
laanwj added a commit that referenced this pull request Jun 11, 2017
@laanwj
Merge #10560: Remove unused constants
562caf1 
dce8239 Comment out unused constant REJECT_DUST (practicalswift)
3289ef4 Remove unused constant MEMPOOL_GD_VERSION (practicalswift)

Tree-SHA512: 8dd772c963037cd0a1db0d5bf5f7a5cce3f5cd8fb6fa983949f9f0c1c8312ffd251a62c1e5d32f3584d2bcc562d8c8a9bf7900609dee9a4f12898caa2be9c38f
@Sjors Sjors mentioned this pull request Mar 14, 2018
Closed
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10560: Remove unused constants
6a0f565 
dce8239 Comment out unused constant REJECT_DUST (practicalswift)
3289ef4 Remove unused constant MEMPOOL_GD_VERSION (practicalswift)

Tree-SHA512: 8dd772c963037cd0a1db0d5bf5f7a5cce3f5cd8fb6fa983949f9f0c1c8312ffd251a62c1e5d32f3584d2bcc562d8c8a9bf7900609dee9a4f12898caa2be9c38f
@practicalswift practicalswift deleted the noop-modes branch April 10, 2021 19:31
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@achow101 achow101 achow101 left review comments

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@practicalswift @achow101 @sipa @fanquake @laanwj