Merged
Conversation
sipa
reviewed
Jun 9, 2017
src/validation.cpp
Outdated
Member
There was a problem hiding this comment.
Can you move this line out of the loop? No need to parse the command line argument for every block.
Member
|
What's up with the random optimisation? |
achow101
force-pushed
the
fix-stopatheight
branch
from
74eed46 to
8f57411
Compare
Moves stopatheight check into the ActivateBestChain loop so that the block height is actually checked and stopped at the appropriate time.
achow101
force-pushed
the
fix-stopatheight
branch
from
8f57411 to
c45cbaf
Compare
Member
Author
|
sorry, checked out from the wrong worktree |
Member
|
utACK c45cbaf |
Contributor
|
utACK c45cbaf |
Member
|
I thought I was doing something wrong :$ As |
laanwj
added a commit
that referenced
this pull request
Jun 11, 2017
c45cbaf Fix stopatheight (Andrew Chow) Tree-SHA512: 7df07ca1d40a5a3a8d93ad8943cd04954d587e19bbb63ed084b7aff9503788ec73a1045fbfc4a36d9775975032c2ee0bcc76eb4da10e879f483eaa6f351c19b2
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 15, 2017
Moves stopatheight check into the ActivateBestChain loop so that the block height is actually checked and stopped at the appropriate time. Github-Pull: bitcoin#10569 Rebased-From: c45cbaf
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 8, 2019
c45cbaf Fix stopatheight (Andrew Chow) Tree-SHA512: 7df07ca1d40a5a3a8d93ad8943cd04954d587e19bbb63ed084b7aff9503788ec73a1045fbfc4a36d9775975032c2ee0bcc76eb4da10e879f483eaa6f351c19b2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves stopatheight check into the ActivateBestChain loop so that the block height is actually checked and stopped at the appropriate time.
Noticed and reported here: #10339 (comment)