Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients#10595
Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients#10595luke-jr wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
utACK 4292a75 |
luke-jr
force-pushed
the
gbt_nosegwit_fix
branch
from
4292a75 to
e36493b
Compare
|
Rebased. At this point, it might make sense to just drop support for pre-segwit miners, but this fix is simple, so it makes sense to get in (and backportable) first. |
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
I agree that we should just drop support for non-segwit miners at this point. Doesn't seem worth the trouble of making this change.
test/functional/feature_segwit.py
Outdated
There was a problem hiding this comment.
nit: prefer assert_equal() for asserting equality
test/functional/feature_segwit.py
Outdated
There was a problem hiding this comment.
nit: assert is a statement, not a function. Please remove parens.
…th non-segwit GBT clients
luke-jr
force-pushed
the
gbt_nosegwit_fix
branch
from
e36493b to
a5464ad
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
This has been "fixed" by
|
| Needs rebase |
7 participants
No description provided.