Use nullptr (C++11) instead of zero (0) as the null pointer constant by practicalswift · Pull Request #10645 · bitcoin/bitcoin

practicalswift · 2017-06-21T19:12:46Z

Use nullptr instead of zero (0) as the null pointer constant.

The road towards nullptr (C++11) is split into two PRs:

NULL → nullptr is handled in PR scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL #10483 (scripted)
0 → nullptr is handled in PR Use nullptr (C++11) instead of zero (0) as the null pointer constant #10645 (manual, this PR)

By using the C++11 keyword nullptr we are guaranteed a prvalue of type std::nullptr_t.

For a more thorough discussion, see "A name for the null pointer: nullptr" (Sutter &
Stroustrup), http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf

jtimon · 2017-06-22T01:26:32Z

utACK a0fbff2c8c0621d2ef4759078b3c690f1c33748b

gmaxwell

Concept ACK

practicalswift · 2017-06-22T19:06:42Z

Rebased!

…the pointer literal instead of the macro NULL 90d4d89 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL (practicalswift) Pull request description: Since C++11 the macro `NULL` may be: * an integer literal with value zero, or * a prvalue of type `std::nullptr_t` By using the C++11 keyword `nullptr` we are guaranteed a prvalue of type `std::nullptr_t`. For a more thorough discussion, see "A name for the null pointer: nullptr" (Sutter & Stroustrup), http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf With this patch applied there are no `NULL` macro usages left in the repo: ``` $ git grep NULL -- "*.cpp" "*.h" | egrep -v '(/univalue/|/secp256k1/|/leveldb/|_NULL|NULLDUMMY|torcontrol.*NULL|NULL cert)' | wc -l 0 ``` The road towards `nullptr` (C++11) is split into two PRs: * `NULL` → `nullptr` is handled in PR #10483 (scripted, this PR) * `0` → `nullptr` is handled in PR #10645 (manual) Tree-SHA512: 3c395d66f2ad724a8e6fed74b93634de8bfc0c0eafac94e64e5194c939499fefd6e68f047de3083ad0b4eff37df9a8a3a76349aa17d55eabbd8e0412f140a297

practicalswift · 2017-08-14T15:40:34Z

@laanwj Thanks for merging the NULL → nullptr PR (#10483). This PR handles the case 0 → nullptr and has now been rebased on top of master.

laanwj · 2017-08-14T17:45:01Z

utACK f71710d

jnewbery

Tested ACK f71710dad454f5afe431479d0aea578b36d68206. Looks good @practicalswift . Thanks for doing this!

One open question for @laanwj

jnewbery · 2017-08-15T21:03:14Z

src/tinyformat.h

There may be an argument to not making style changes to tinyformat.h, which occasionally pulls in changes from upstream. Don't know what @laanwj's view is on this?

Agree, we should generally minimize changes to tinyformat.h, and if it is just style it just adds burden on us with no clear gain.

If you get upstream to accept this it's okay with me. But I think they want to keep compatiblity with older C++.

practicalswift · 2017-08-16T08:25:35Z

@jnewbery @laanwj Good point! The change to src/tinyformat.h is no longer included in this PR.

…nter constant 36d326e Use nullptr instead of zero (0) as the null pointer constant (practicalswift) Pull request description: Use `nullptr` instead of zero (0) as the null pointer constant. The road towards `nullptr` (C++11) is split into two PRs: * `NULL` → `nullptr` is handled in PR #10483 (scripted) * `0` → `nullptr` is handled in PR #10645 (manual, this PR) By using the C++11 keyword `nullptr` we are guaranteed a prvalue of type `std::nullptr_t`. For a more thorough discussion, see "A name for the null pointer: nullptr" (Sutter & Stroustrup), http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf Tree-SHA512: 5412404b40a94ea2d9fc8f81573559c4ffe559749301d486b09d41a7a736345ad602d08ac590930bb00a49692b6075520cf3d543e4da6ccd5b29fa9bcc3f15ea

bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift) Pull request description: Document the preference of `nullptr` over `NULL` or `(void*)0`. After this commit: ``` $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)' $ ``` Some context: * `NULL → nullptr` was handled in the recently merged PR #10483 * `0 → nullptr` was handled in the recently merged PR #10645 Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a

…ull pointer constant 36d326e Use nullptr instead of zero (0) as the null pointer constant (practicalswift) Pull request description: Use `nullptr` instead of zero (0) as the null pointer constant. The road towards `nullptr` (C++11) is split into two PRs: * `NULL` → `nullptr` is handled in PR bitcoin#10483 (scripted) * `0` → `nullptr` is handled in PR bitcoin#10645 (manual, this PR) By using the C++11 keyword `nullptr` we are guaranteed a prvalue of type `std::nullptr_t`. For a more thorough discussion, see "A name for the null pointer: nullptr" (Sutter & Stroustrup), http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf Tree-SHA512: 5412404b40a94ea2d9fc8f81573559c4ffe559749301d486b09d41a7a736345ad602d08ac590930bb00a49692b6075520cf3d543e4da6ccd5b29fa9bcc3f15ea

…(void*)0 bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift) Pull request description: Document the preference of `nullptr` over `NULL` or `(void*)0`. After this commit: ``` $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)' $ ``` Some context: * `NULL → nullptr` was handled in the recently merged PR bitcoin#10483 * `0 → nullptr` was handled in the recently merged PR bitcoin#10645 Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a

…ull pointer constant 36d326e Use nullptr instead of zero (0) as the null pointer constant (practicalswift) Pull request description: Use `nullptr` instead of zero (0) as the null pointer constant. The road towards `nullptr` (C++11) is split into two PRs: * `NULL` → `nullptr` is handled in PR bitcoin#10483 (scripted) * `0` → `nullptr` is handled in PR bitcoin#10645 (manual, this PR) By using the C++11 keyword `nullptr` we are guaranteed a prvalue of type `std::nullptr_t`. For a more thorough discussion, see "A name for the null pointer: nullptr" (Sutter & Stroustrup), http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf Tree-SHA512: 5412404b40a94ea2d9fc8f81573559c4ffe559749301d486b09d41a7a736345ad602d08ac590930bb00a49692b6075520cf3d543e4da6ccd5b29fa9bcc3f15ea

Cherry-picked from: - bitcoin/bitcoin#9233 - bitcoin/bitcoin#10483 - bitcoin/bitcoin#10645 - bitcoin/bitcoin#10969 - bitcoin/bitcoin#11351 Co-authored-by: fsb4000 <[email protected]> Co-authored-by: practicalswift <[email protected]> Co-authored-by: Dan Raviv <[email protected]>

Locked memory manager Add a pool for locked memory chunks, replacing `LockedPageManager`. Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#8321 - bitcoin/bitcoin#8753 - bitcoin/bitcoin#9063 - bitcoin/bitcoin#9070 - bitcoin/bitcoin#11385 - bitcoin/bitcoin#12048 - Excludes change to benchmark. - bitcoin/bitcoin#15117 - bitcoin/bitcoin#16161 - Excludes Travis CI changes. - Includes change from bitcoin/bitcoin#13163 - bitcoin/bitcoin#15600 - bitcoin/bitcoin#18443 - Assorted small changes from: - bitcoin/bitcoin#9233 - bitcoin/bitcoin#10483 - bitcoin/bitcoin#10645 - bitcoin/bitcoin#10969 - bitcoin/bitcoin#11351 - bitcoin/bitcoin#19111 - Excludes change to `src/rpc/server.cpp` - bitcoin/bitcoin#9804 - Only the commit for `src/key.cpp` - bitcoin/bitcoin#9598

…ull pointer constant 36d326e Use nullptr instead of zero (0) as the null pointer constant (practicalswift) Pull request description: Use `nullptr` instead of zero (0) as the null pointer constant. The road towards `nullptr` (C++11) is split into two PRs: * `NULL` → `nullptr` is handled in PR bitcoin#10483 (scripted) * `0` → `nullptr` is handled in PR bitcoin#10645 (manual, this PR) By using the C++11 keyword `nullptr` we are guaranteed a prvalue of type `std::nullptr_t`. For a more thorough discussion, see "A name for the null pointer: nullptr" (Sutter & Stroustrup), http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf Tree-SHA512: 5412404b40a94ea2d9fc8f81573559c4ffe559749301d486b09d41a7a736345ad602d08ac590930bb00a49692b6075520cf3d543e4da6ccd5b29fa9bcc3f15ea

…(void*)0 bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift) Pull request description: Document the preference of `nullptr` over `NULL` or `(void*)0`. After this commit: ``` $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)' $ ``` Some context: * `NULL → nullptr` was handled in the recently merged PR bitcoin#10483 * `0 → nullptr` was handled in the recently merged PR bitcoin#10645 Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a

…ull pointer constant 36d326e Use nullptr instead of zero (0) as the null pointer constant (practicalswift) Pull request description: Use `nullptr` instead of zero (0) as the null pointer constant. The road towards `nullptr` (C++11) is split into two PRs: * `NULL` → `nullptr` is handled in PR bitcoin#10483 (scripted) * `0` → `nullptr` is handled in PR bitcoin#10645 (manual, this PR) By using the C++11 keyword `nullptr` we are guaranteed a prvalue of type `std::nullptr_t`. For a more thorough discussion, see "A name for the null pointer: nullptr" (Sutter & Stroustrup), http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf Tree-SHA512: 5412404b40a94ea2d9fc8f81573559c4ffe559749301d486b09d41a7a736345ad602d08ac590930bb00a49692b6075520cf3d543e4da6ccd5b29fa9bcc3f15ea

…(void*)0 bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift) Pull request description: Document the preference of `nullptr` over `NULL` or `(void*)0`. After this commit: ``` $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)' $ ``` Some context: * `NULL → nullptr` was handled in the recently merged PR bitcoin#10483 * `0 → nullptr` was handled in the recently merged PR bitcoin#10645 Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a

practicalswift mentioned this pull request Jun 21, 2017

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL #10483

Merged

practicalswift force-pushed the welcome-nullptr-goodbye-0 branch from 4add252 to a0fbff2 Compare June 21, 2017 19:44

practicalswift changed the title ~~Use nullptr instead of zero (0) as the null pointer constant~~ Use nullptr (C++11) instead of zero (0) as the null pointer constant Jun 21, 2017

fanquake added the Refactoring label Jun 21, 2017

gmaxwell reviewed Jun 22, 2017

View reviewed changes

practicalswift force-pushed the welcome-nullptr-goodbye-0 branch from a0fbff2 to b1975c0 Compare June 22, 2017 19:06

practicalswift force-pushed the welcome-nullptr-goodbye-0 branch from b1975c0 to 93ebb25 Compare August 9, 2017 08:44

practicalswift force-pushed the welcome-nullptr-goodbye-0 branch from c5e92c4 to f71710d Compare August 14, 2017 15:37

dcousens approved these changes Aug 15, 2017

View reviewed changes

jnewbery reviewed Aug 15, 2017

View reviewed changes

Use nullptr instead of zero (0) as the null pointer constant

36d326e

practicalswift force-pushed the welcome-nullptr-goodbye-0 branch from f71710d to 36d326e Compare August 16, 2017 08:24

maflcko merged commit 36d326e into bitcoin:master Aug 16, 2017

practicalswift mentioned this pull request Aug 16, 2017

Document the preference of nullptr over NULL or (void*)0 #11066

Merged

Empact mentioned this pull request Jan 5, 2019

build: Optionally enable -Wzero-as-null-pointer-constant #15112

Closed

str4d mentioned this pull request Jul 31, 2020

Locked memory manager zcash/zcash#4643

Merged

practicalswift deleted the welcome-nullptr-goodbye-0 branch April 10, 2021 19:32

barton2526 mentioned this pull request Jun 12, 2021

refactor: misc style changes gridcoin-community/Gridcoin-Research#2177

Merged

bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use nullptr (C++11) instead of zero (0) as the null pointer constant#10645

Use nullptr (C++11) instead of zero (0) as the null pointer constant#10645
maflcko merged 1 commit intobitcoin:masterfrom
practicalswift:welcome-nullptr-goodbye-0

practicalswift commented Jun 21, 2017 •

edited

Loading

Uh oh!

jtimon commented Jun 22, 2017

Uh oh!

gmaxwell left a comment

Uh oh!

practicalswift commented Jun 22, 2017

Uh oh!

practicalswift commented Aug 14, 2017

Uh oh!

laanwj commented Aug 14, 2017

Uh oh!

jnewbery left a comment

Uh oh!

jnewbery Aug 15, 2017

Uh oh!

laanwj Aug 16, 2017

Uh oh!

practicalswift commented Aug 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

practicalswift commented Jun 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtimon commented Jun 22, 2017

Uh oh!

gmaxwell left a comment

Choose a reason for hiding this comment

Uh oh!

practicalswift commented Jun 22, 2017

Uh oh!

practicalswift commented Aug 14, 2017

Uh oh!

laanwj commented Aug 14, 2017

Uh oh!

jnewbery left a comment

Choose a reason for hiding this comment

Uh oh!

jnewbery Aug 15, 2017

Choose a reason for hiding this comment

Uh oh!

laanwj Aug 16, 2017

Choose a reason for hiding this comment

Uh oh!

practicalswift commented Aug 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

practicalswift commented Jun 21, 2017 •

edited

Loading