Add optional wallet=filename arguments to wallet RPCs#10661
Closed
ryanofsky wants to merge 1 commit intobitcoin:masterfrom
Closed
Add optional wallet=filename arguments to wallet RPCs#10661ryanofsky wants to merge 1 commit intobitcoin:masterfrom
ryanofsky wants to merge 1 commit intobitcoin:masterfrom
Conversation
ryanofsky
changed the title
Member
|
Same comment as on #10653 (comment)**** |
This change adds an optional wallet=filename argument to RPCs that access the
wallet so they can operate on wallets other than the default wallet.
Example usage:
bitcoind -regtest -wallet=w1.dat -wallet=w2.dat
bitcoin-cli -regtest -named getwalletinfo wallet=w1.dat
bitcoin-cli -regtest -named getwalletinfo wallet=w2.dat
bitcoin-cli -regtest -named getbalance wallet=w2.dat
Contributor
Author
|
Closing in favor of #10650 (https://botbot.me/freenode/bitcoin-core-dev/msg/88240462/) There's also a newer version of this PR which adds a test & makes it an error not to specify a wallet when more than one is loaded: master...ryanofsky:pr/multiopt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an optional wallet=filename argument to RPCs that access the
wallet so they can operate on wallets other than the default wallet.
This does essentially the same thing as #10653, except it adds support for new wallet parameters explicitly in individual RPC methods instead of implicitly at the RPC dispatching layer.
Example usage: