ACK 0357ce0 (trivial review)

All aboard the obvious-ACK train :).

utACK.

utACK 0357ce0

utACK 0357ce0

Nit: We expect to find primitives/transaction.h locally in src/.

utACK as it matches the common convention better.

Though sometimes I wonder whether this convention is a good idea. include <> searches relative to the include paths, include "" relative to the directory of the current source file, then the include paths. We know primitives/ is relative to the source root of the repository, so it doesn't really need to look anywhere else. Especially not if it is already in primitives/, e.g.

• when primitives/block.h includes "primitives/transaction.h", then it makes it look in src/primitives/primitives
• when src/wallet/feebumper.h includes "primitives/transaction.h", it makes it look in src/wallet/primitives!

So with regard to unambiguity, this is a change for the worse.

The advantage of using #include "primitives/transaction.h" instead of simply #include "transaction.h" is that one day we may want to search and replace all #include "primitives/transaction.h" say, to a new directory. If you moved primitives/block.o to the same directory at the same time it would be fine though.

Added a commit fixing the same thing when importing wallet/wallet.h :-) Introduced in 9737572.

If you don't mind, I'm going to close this. There has been talk of moving to absolute inclusion (e.g. #include <>) instead on the longer run (#10976 (comment)) and I think that'd be superior.

Makes sense! :-)