Add PR description to merge commit in github-merge.py#10786
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jul 11, 2017
Merged
Add PR description to merge commit in github-merge.py#10786laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
ACK
…On Mon, Jul 10, 2017 at 9:49 PM, Pieter Wuille ***@***.***> wrote:
There is often some context given in PR descriptions that is missing from
commits, and it may be worthwhile to retain that information in our history
in git. This PR adds that information to the merge commit when created
through github-merge.py.
We should also encourage people to provide as much information as possible
in the PR commits themselves, but I believe that is an orthogonal issue.
Individual commits don't need to have a description of the overall goal of
a PR.
------------------------------
You can view, comment on, or merge this pull request online at:
#10786
Commit Summary
- Add PR description to merge commit in github-merge.py
File Changes
- *M* contrib/devtools/github-merge.py
<https://github.com/bitcoin/bitcoin/pull/10786/files#diff-0> (2)
Patch Links:
- https://github.com/bitcoin/bitcoin/pull/10786.patch
- https://github.com/bitcoin/bitcoin/pull/10786.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10786>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv2dCxNyQQJAXY55qxT8K8F0DFQXRks5sMoBSgaJpZM4OTU0D>
.
|
promag
reviewed
Jul 10, 2017
contrib/devtools/github-merge.py
Outdated
Contributor
There was a problem hiding this comment.
I think here should be body = info['body'].strip() like the above. And the body indentation should be below.
Contributor
|
ACK 475c08c. For the record, after this, the PR description must be part of the review process. Don't forget that there can be typos, markdown, links for temporary resources, etc that will be written in stone. Maybe for future improvement is to print the body and prompt for confirmation. |
Contributor
|
Great idea. |
Member
|
Concept ACK |
laanwj
added a commit
that referenced
this pull request
Jul 11, 2017
475c08c Add PR description to merge commit in github-merge.py (Pieter Wuille) Pull request description: There is often some context given in PR descriptions that is missing from commits, and it may be worthwhile to retain that information in our history in git. This PR adds that information to the merge commit when created through `github-merge.py`. We should also encourage people to provide as much information as possible in the PR commits themselves, but I believe that is an orthogonal issue. Individual commits don't need to have a description of the overall goal of a PR. Tree-SHA512: cbae46ec24ce911744e11a07e5d51895d3acc79659db306d8124304ef8e422bba99001ee2a741b08c92a5eb39d9c3f6b723622b20d6553ca5cfa0a8de866194c
Contributor
|
I guess we are fine with HTML code in the PR description (=> goes then into git commit message)? |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 18, 2019
…ge.py 475c08c Add PR description to merge commit in github-merge.py (Pieter Wuille) Pull request description: There is often some context given in PR descriptions that is missing from commits, and it may be worthwhile to retain that information in our history in git. This PR adds that information to the merge commit when created through `github-merge.py`. We should also encourage people to provide as much information as possible in the PR commits themselves, but I believe that is an orthogonal issue. Individual commits don't need to have a description of the overall goal of a PR. Tree-SHA512: cbae46ec24ce911744e11a07e5d51895d3acc79659db306d8124304ef8e422bba99001ee2a741b08c92a5eb39d9c3f6b723622b20d6553ca5cfa0a8de866194c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is often some context given in PR descriptions that is missing from commits, and it may be worthwhile to retain that information in our history in git. This PR adds that information to the merge commit when created through
github-merge.py.We should also encourage people to provide as much information as possible in the PR commits themselves, but I believe that is an orthogonal issue. Individual commits don't need to have a description of the overall goal of a PR.