Merged
Conversation
dcousens
approved these changes
Jul 16, 2017
src/test/dbwrapper_tests.cpp
Outdated
Contributor
There was a problem hiding this comment.
Nit: Please use the form for (int x: {1, 2}) instead of for (int x: { 1, 2 } ).
The former is the dominant form used in the repo:
$ git grep -E "\{(true|false|0|1|2)" -- "*.cpp" | wc -l
112
$ git grep -E "\{ (true|false|0|1|2)" -- "*.cpp" | wc -l
9
Contributor
|
utACK ab005dd40dfc3e0e4ec126bbfc8144cd8a42e741 |
Member
|
Make sure to adhere to the developer notes when touching code.
https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#developer-notes
There is even a link to a clang format script which should take care of
white space and braces for you.
…On Sun, Jul 16, 2017 at 4:19 PM, practicalswift ***@***.***> wrote:
utACK ab005dd
<ab005dd>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10844 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv8DqLkFasoqXf5536iTb7Fn3OIgpks5sOhv-gaJpZM4OZTbC>
.
|
Instead of iterating over 0 .. 1 and then deciding on an actual desired value, use a range based for loop for the desired value.
ReneNyffenegger
force-pushed
the
dbwrapper_tests-for
branch
from
ab005dd to
d0413c6
Compare
Contributor
Author
|
I was unaware of the clang format script. Thaks for the pointer. I let it change the commit, and squashed and force-pushed it. |
Contributor
|
utACK d0413c6 |
1 similar comment
Member
|
utACK d0413c6 |
sipa
added a commit
that referenced
this pull request
Jul 16, 2017
d0413c6 Use range based for loop (René Nyffenegger) Pull request description: Instead of iterating over 0 .. 1 and then deciding on an actual desired value, use a range based for loop for the desired value. Tree-SHA512: 0a7a4a80516c9f16cf97fa7d257088b8386360e19b93c4deac3d745b6270ea452c513821686d7d14a159a235763e034f9b14eef222ca15f7eb71c37bd1c2c380
Member
|
utACK d0413c6 |
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 4, 2018
Additional dbwrapper tests Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7992 - bitcoin/bitcoin#9867 - Only the commit affecting dbwrapper tests - bitcoin/bitcoin#9610 - Only the change affecting dbwrapper tests - bitcoin/bitcoin#10844
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 24, 2019
d0413c6 Use range based for loop (René Nyffenegger) Pull request description: Instead of iterating over 0 .. 1 and then deciding on an actual desired value, use a range based for loop for the desired value. Tree-SHA512: 0a7a4a80516c9f16cf97fa7d257088b8386360e19b93c4deac3d745b6270ea452c513821686d7d14a159a235763e034f9b14eef222ca15f7eb71c37bd1c2c380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of iterating over 0 .. 1 and then deciding on an actual desired
value, use a range based for loop for the desired value.