Update .gitignore to ignore more test files#10880
Closed
eklitzke wants to merge 1 commit intobitcoin:masterfrom
Closed
Update .gitignore to ignore more test files#10880eklitzke wants to merge 1 commit intobitcoin:masterfrom
eklitzke wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
Concept ACK |
| coverage_percent.txt | ||
|
|
||
| #build tests | ||
| qa/ |
Contributor
There was a problem hiding this comment.
qa/ should no longer be created in current master. If this is still the case, we should rather find the source why this was created then just ignoring it.
Member
There was a problem hiding this comment.
I haven't seen any instances of it being created in new trees, so most probably if you have this, it's a remainder from an old build.
| .libs | ||
| .*.swp | ||
| *.*~* | ||
| *.backup |
Contributor
There was a problem hiding this comment.
I guess this would not hurt, though I think we should cleanup the backup file (unlink them) in wallet_test.cpp.
Member
There was a problem hiding this comment.
Not only that, but we shouldn't be creating a wallet.backup file in the src directory at all. It should go in the temporary directory created for the other test files.
Sounds like a really bad thing now, someone could confuse it for a real wallet backup, for one.
Thanks for noticing @eklitzke.
Contributor
|
Concept ACK. |
laanwj
added a commit
to laanwj/bitcoin
that referenced
this pull request
Jul 25, 2017
This assures that we don't overwrite a random file called `wallet.backup` that happens to be in the current directory. It also assures that the temporary file will be cleaned up. Noticed by Evan Klitzke, came up in discussion here: bitcoin#10880 (comment)
laanwj
added a commit
that referenced
this pull request
Jul 25, 2017
88af227 test: Make sure wallet.backup is created in temp path (Wladimir J. van der Laan) Pull request description: This assures that we don't overwrite a random file called `wallet.backup` that happens to be in the current directory. It also assures that the temporary file will be cleaned up. Noticed by Evan Klitzke, came up in discussion here: #10880 (comment) Tree-SHA512: 2d2c23c2deba26a1130a29279b3d8565b277eb90a98a6a6d7dd4948f5cbbd5ec5453b3082e3e4e21e0e2423e642bbd2f4433e4c21032d3c8cff27ee35e87e7e7
Member
|
@eklitzke Are you still working on this?
|
Contributor
Author
|
It looks like I get a clean environment when building on master, including when running the test suite. Previously I had built Bitcoin from a release tag. For this reason, I'm closing the PR. |
mempko
pushed a commit
to meritlabs/merit
that referenced
this pull request
Sep 28, 2017
This assures that we don't overwrite a random file called `wallet.backup` that happens to be in the current directory. It also assures that the temporary file will be cleaned up. Noticed by Evan Klitzke, came up in discussion here: bitcoin/bitcoin#10880 (comment)
mempko
pushed a commit
to meritlabs/merit
that referenced
this pull request
Sep 28, 2017
88af227 test: Make sure wallet.backup is created in temp path (Wladimir J. van der Laan) Pull request description: This assures that we don't overwrite a random file called `wallet.backup` that happens to be in the current directory. It also assures that the temporary file will be cleaned up. Noticed by Evan Klitzke, came up in discussion here: bitcoin/bitcoin#10880 (comment) Tree-SHA512: 2d2c23c2deba26a1130a29279b3d8565b277eb90a98a6a6d7dd4948f5cbbd5ec5453b3082e3e4e21e0e2423e642bbd2f4433e4c21032d3c8cff27ee35e87e7e7
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 2, 2019
… path 88af227 test: Make sure wallet.backup is created in temp path (Wladimir J. van der Laan) Pull request description: This assures that we don't overwrite a random file called `wallet.backup` that happens to be in the current directory. It also assures that the temporary file will be cleaned up. Noticed by Evan Klitzke, came up in discussion here: bitcoin#10880 (comment) Tree-SHA512: 2d2c23c2deba26a1130a29279b3d8565b277eb90a98a6a6d7dd4948f5cbbd5ec5453b3082e3e4e21e0e2423e642bbd2f4433e4c21032d3c8cff27ee35e87e7e7
charlesrocket
pushed a commit
to AXErunners/axe
that referenced
this pull request
Nov 29, 2019
88af227 test: Make sure wallet.backup is created in temp path (Wladimir J. van der Laan) Pull request description: This assures that we don't overwrite a random file called `wallet.backup` that happens to be in the current directory. It also assures that the temporary file will be cleaned up. Noticed by Evan Klitzke, came up in discussion here: bitcoin/bitcoin#10880 (comment) Tree-SHA512: 2d2c23c2deba26a1130a29279b3d8565b277eb90a98a6a6d7dd4948f5cbbd5ec5453b3082e3e4e21e0e2423e642bbd2f4433e4c21032d3c8cff27ee35e87e7e7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, after building bitcoin master and testing it, I see the following untracked files:
I've tried to keep the
.gitignorelines in the appropriate sections of the file.