Encapsulate RPC command implementations within new classes#1102
Closed
jgarzik wants to merge 1 commit intobitcoin:masterfrom
Closed
Encapsulate RPC command implementations within new classes#1102jgarzik wants to merge 1 commit intobitcoin:masterfrom
jgarzik wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
Author
|
Closing, as people seem to prefer #1103 |
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* add GetStateString and static CMasternode::StateToString helpers * Fix CActiveMasternode: - should run `ManageStateLocal` only when `eType == MASTERNODE_LOCAL` - should set `nState = ACTIVE_MASTERNODE_NOT_CAPABLE` in `ManageStateInitial` to let `GetStatus` return proper message - more/better log output
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
[qa] test_framework: Use different rpc_auth_pair for each node
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Apr 21, 2020
…isig 10bcb05 Fix parsing of redeemkey of omni_createrawtx_multisig (dexX7) Pull request description: This pull request fixes faulty parsing of redeem key of omni_createrawtx_multisig. Tree-SHA512: b04954cf34ab1c102cad0d622ddd212ff4a795706a7085078dd97f839fd0a0052b4e6eecdfb3fcb0636ca48a84a0d4b76efb52856d0b9203496e0c71dd1f812f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes RPC a bit more object-oriented. All RPC commands now derive from a common base class, CRPCCommand.