Merged
Conversation
Member
|
utACK. @instagibbs had an unrelated build failure due to (auto) jni detection in libsecp256k1. Regardless of that problem (which should be addressed), we should be deterministic in the downstream features we enable/build. |
Member
|
What is jni and how would it possibly have any influence on us? |
Member
|
libsecp256k1 has (optional) JNI bindings |
Contributor
|
utACK 844b73e though I think the libsecp256k1 JNI (java native interface) default should not be auto ("no" as default makes more sense IMO). |
Member
|
If the answer is that it doesn't affect us in any way, then it should be disabled, I agree. If anything it's a waste of resources building. utACK. |
Member
|
ACK 844b73e |
sickpig
referenced
this pull request
in sickpig/BitcoinUnlimited
Oct 19, 2017
844b73e disable jni in builds (Gregory Sanders) Pull request description: Suggested by @theuni Unneeded and was causing travis issues downstream. Tree-SHA512: 6e302d6fd73cf09c72269e7976cc40e64abdea780278c7333a5196f188f9dede12944f1e03605ec7d194b245213d0a2576bfbdbd0f6ba20154e0e9a68008851c
gmaxwell
added a commit
to bitcoin-core/secp256k1
that referenced
this pull request
Feb 6, 2018
57752d2 [build] Set --enable-jni to no by default instead of auto. (Karl-Johan Alm) Pull request description: Having `--enable-jni` be `auto` doesn't make a lot of sense, and results in things like bitcoin/bitcoin#11056. Tree-SHA512: 27d6ea041f5d6e249857869ab87b8f7b1f6d18ec5ec82d2c46e692cd690b9f5c5857886725901a29d3539d427d8b6154d0c7909cfa2ce30bb3d4460c05708386
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 2, 2019
Github-Pull: bitcoin#11056 Rebased-From: 844b73e Tree-SHA512: f735853c3d9abbde5032cc55201b0ddc29679e681ba7d3822cbcbeee17c7185ee984b235411224cfb8ff12550de88a0f1367d55ad24bf52c5c03061330849eb2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @theuni
Unneeded and was causing travis issues downstream.