Skip to content

Document the preference of nullptr over NULL or (void*)0#11066

Merged
laanwj merged 1 commit intobitcoin:masterfrom
practicalswift:document-nullptr-preference
Aug 18, 2017
Merged

Document the preference of nullptr over NULL or (void*)0#11066
laanwj merged 1 commit intobitcoin:masterfrom
practicalswift:document-nullptr-preference

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Aug 16, 2017 •
edited
Loading

Document the preference of nullptr over NULL or (void*)0.

After this commit:

$ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)'
$

Some context:

@promag
Copy link
Contributor

promag commented Aug 16, 2017 •
edited
Loading

utACK 12e881b.

BTW, should be if (psomething) or if (psomething != nullptr), etc?

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Aug 16, 2017

utACK

@maflcko maflcko added the Docs label Aug 16, 2017
@maflcko
Copy link
Member

maflcko commented Aug 16, 2017

utACK

gmaxwell
gmaxwell approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@gmaxwell gmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@sipa
Copy link
Member

sipa commented Aug 16, 2017

utACK 12e881b4ded62c0b09f9a09df5b2efc1966db50b

@paveljanik
Copy link
Contributor

paveljanik commented Aug 16, 2017

utACK 12e881b

Can you please handle these:

src/qt/macdockiconhandler.mm:static MacDockIconHandler *s_instance = NULL;
src/qt/macdockiconhandler.mm:    if (appInst != NULL) {
src/qt/macdockiconhandler.mm:    this->setMainWindow(NULL);
src/qt/macdockiconhandler.mm:    this->setMainWindow(NULL);
src/qt/macnotificationhandler.mm:    static MacNotificationHandler *s_instance = NULL;

@practicalswift practicalswift force-pushed the document-nullptr-preference branch from 12e881b to 3f3cf36 Compare August 16, 2017 19:00
@practicalswift
Copy link
Contributor Author

practicalswift commented Aug 16, 2017

@paveljanik Fixed! :-)

@fanquake
Copy link
Member

fanquake commented Aug 17, 2017

utACK 3f3cf36

@laanwj
Copy link
Member

laanwj commented Aug 17, 2017

Can you please handle these: <*.mm>

Are you sure that's safe? Isn't that some C++ mongrel? Does "Objective C++" have the same rules as C++11 in this regard?

@paveljanik
Copy link
Contributor

paveljanik commented Aug 17, 2017

See e.g. Apple's sample programs (https://developer.apple.com/library/content/samplecode/GL3_Text/Listings/Sources_Toolkits_OpenGL_Shaders_GLUProgram_mm.html). It should be safe.

@laanwj
Copy link
Member

laanwj commented Aug 18, 2017

It should be safe.

OK. Just wanted to bring it up.

Seems to need rebase now.

@laanwj laanwj self-assigned this Aug 18, 2017
@practicalswift practicalswift force-pushed the document-nullptr-preference branch from 3f3cf36 to bea8e9e Compare August 18, 2017 07:51
@practicalswift
Copy link
Contributor Author

practicalswift commented Aug 18, 2017

Rebased! :-)

@laanwj laanwj merged commit bea8e9e into bitcoin:master Aug 18, 2017
laanwj added a commit that referenced this pull request Aug 18, 2017
@laanwj
Merge #11066: Document the preference of nullptr over NULL or (void*)0
9e00a62 
bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift)

Pull request description:

  Document the preference of `nullptr` over `NULL` or `(void*)0`.

  After this commit:

  ```
  $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)'
  $
  ```

  Some context:
  * `NULL → nullptr` was handled in the recently merged PR #10483
  * `0 → nullptr` was handled in the recently merged PR #10645

Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 9, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#11066: Document the preference of nullptr over NULL or …
47a0b82 
…(void*)0

bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift)

Pull request description:

  Document the preference of `nullptr` over `NULL` or `(void*)0`.

  After this commit:

  ```
  $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)'
  $
  ```

  Some context:
  * `NULL → nullptr` was handled in the recently merged PR bitcoin#10483
  * `0 → nullptr` was handled in the recently merged PR bitcoin#10645

Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11066: Document the preference of nullptr over NULL or …
9d58c98 
…(void*)0

bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift)

Pull request description:

  Document the preference of `nullptr` over `NULL` or `(void*)0`.

  After this commit:

  ```
  $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)'
  $
  ```

  Some context:
  * `NULL → nullptr` was handled in the recently merged PR bitcoin#10483
  * `0 → nullptr` was handled in the recently merged PR bitcoin#10645

Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a
@practicalswift practicalswift deleted the document-nullptr-preference branch April 10, 2021 19:32
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 26, 2021
@laanwj
Merge bitcoin#11066: Document the preference of nullptr over NULL or …
651b724 
…(void*)0

bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift)

Pull request description:

  Document the preference of `nullptr` over `NULL` or `(void*)0`.

  After this commit:

  ```
  $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)'
  $
  ```

  Some context:
  * `NULL → nullptr` was handled in the recently merged PR bitcoin#10483
  * `0 → nullptr` was handled in the recently merged PR bitcoin#10645

Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Feb 22, 2022
@laanwj @gades
Merge bitcoin#11066: Document the preference of nullptr over NULL or …
4dd3ea4 
…(void*)0

bea8e9e Document the preference of nullptr over NULL or (void*)0 (practicalswift)

Pull request description:

  Document the preference of `nullptr` over `NULL` or `(void*)0`.

  After this commit:

  ```
  $ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)'
  $
  ```

  Some context:
  * `NULL → nullptr` was handled in the recently merged PR bitcoin#10483
  * `0 → nullptr` was handled in the recently merged PR bitcoin#10645

Tree-SHA512: f863096aa4eb21705910f89713ca9cc0d83c6df2147e3d3530c3e1589b96f6c68de8755dcf37d8ce99ebda3cfb69805e00eab13bf65424aaf16170e9dda3958a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dcousens dcousens dcousens approved these changes

@gmaxwell gmaxwell gmaxwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@laanwj laanwj

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@practicalswift @promag @TheBlueMatt @maflcko @sipa @paveljanik @fanquake @laanwj @dcousens @gmaxwell