Remove redundant testutil.cpp|h files#11234
Merged
laanwj merged 1 commit intobitcoin:masterfrom Sep 5, 2017
meshcollider:201709_remove_testutil
Merged
Remove redundant testutil.cpp|h files#11234laanwj merged 1 commit intobitcoin:masterfrom meshcollider:201709_remove_testutil
laanwj merged 1 commit intobitcoin:masterfrom
meshcollider:201709_remove_testutil
Conversation
dcousens
approved these changes
Sep 5, 2017
Contributor
|
utACK d1138e3. Nice cleanup! |
Member
That's why I kept it around, but yeah, if someone wants a test utility cpp/h they can re-add it. |
Member
|
utACK d1138e3. The file collapsed after removal of boost. |
laanwj
added a commit
that referenced
this pull request
Sep 5, 2017
d1138e3 Remove redundant testutil files (MeshCollider) Pull request description: The only function in testutil.cpp, `GetTempPath()` simply called `fs::temp_directory_path()` directly. This just tidies things up by removing that redundant function and the file containing it I can understand wanting a general util file for tests to use, but if there's nothing in it, we might as well remove it, it can always be added back later when it's put to use. Tree-SHA512: b923f99acf33328743755368a1aa90f5da4a7d5f61b163a4b0b894275c98db80a91edf8f051fbfb4893d970fda5a9078aae78a2672867ff521c4ca4b653c71c0
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2017
Github-Pull: bitcoin#11234 Rebased-From: d1138e3
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 24, 2019
d1138e3 Remove redundant testutil files (MeshCollider) Pull request description: The only function in testutil.cpp, `GetTempPath()` simply called `fs::temp_directory_path()` directly. This just tidies things up by removing that redundant function and the file containing it I can understand wanting a general util file for tests to use, but if there's nothing in it, we might as well remove it, it can always be added back later when it's put to use. Tree-SHA512: b923f99acf33328743755368a1aa90f5da4a7d5f61b163a4b0b894275c98db80a91edf8f051fbfb4893d970fda5a9078aae78a2672867ff521c4ca4b653c71c0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only function in testutil.cpp,
GetTempPath()simply calledfs::temp_directory_path()directly. This just tidies things up by removing that redundant function and the file containing itI can understand wanting a general util file for tests to use, but if there's nothing in it, we might as well remove it, it can always be added back later when it's put to use.