Add -usehd to excluded args in check-doc.py#11285
Merged
sipa merged 1 commit intobitcoin:masterfrom Sep 8, 2017
meshcollider:201709_fix_usehd_checkdocs
Merged
Add -usehd to excluded args in check-doc.py#11285sipa merged 1 commit intobitcoin:masterfrom meshcollider:201709_fix_usehd_checkdocs
sipa merged 1 commit intobitcoin:masterfrom
meshcollider:201709_fix_usehd_checkdocs
Conversation
Member
|
Failing as below, however it looks like it's only the arm-linux builds? |
Contributor
Author
|
@fanquake it's only on the builds which export CHECK_DOC=1 to run check-doc.py |
Contributor
|
ACK 7d03418. |
Member
|
travis-has-passed ACK 7d03418 Does a reminder need to be added to the docs somewhere, so this doesn't happen again? |
Contributor
Author
|
Unsure where it would be suitable to put such a thing, but if you have a place in mind it would probably be a good idea 👍 |
Contributor
This problem should have been fixed in #11250 where travis should be broken (but the build was cancelled) so I guess there is no need for documentation. |
Contributor
|
ACK 7d03418 |
Member
|
ACK 7d03418 |
sipa
added a commit
that referenced
this pull request
Sep 8, 2017
7d03418 Add -usehd to excluded args in check-doc.py (MeshCollider) Pull request description: All Travis builds on master are currently failing due to contrib/devtools/check-doc.py picking up `-usehd` in `src/wallet/wallet.cpp#L3845` as an undocumented argument (removed in #11250). Just need to add it to the list of unsupported, deprecated and duplicate args in check-doc.py so that it's ignored. Otherwise all builds on top of #11250 will fail until this is merged. Tree-SHA512: 205c9be759b04bc3b85ac2b53fd455b3c0e229320d8e2b7f7d0ef5d5bd8033594b38a2d948250894ee2f4451584aca698476cd4b5cdf82955925683e3068a67c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Travis builds on master are currently failing due to contrib/devtools/check-doc.py picking up
-usehdinsrc/wallet/wallet.cpp#L3845as an undocumented argument (removed in #11250). Just need to add it to the list of unsupported, deprecated and duplicate args in check-doc.py so that it's ignored. Otherwise all builds on top of #11250 will fail until this is merged.