add m_added_nodes to connman options#11301
Merged
sipa merged 2 commits intobitcoin:masterfrom Sep 22, 2017
Merged
Conversation
added 2 commits
September 11, 2017 16:17
dcousens
approved these changes
Sep 11, 2017
Contributor
|
utACK 35e5c22 |
Member
|
Concept ACK, but I'd like @theuni's review. |
Contributor
|
slightly tested ACk 35e5c22 |
theuni
approved these changes
Sep 15, 2017
Member
theuni
left a comment
theuni
left a comment
There was a problem hiding this comment.
utACK 35e5c22
Though thread sanitizers may complain about the missing lock.
As a follow-up, mind moving Init() out of the header and into the cpp so that we can add more logic as necessary there? In this case, adding back the lock.
Author
|
Ready for merge? |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.