[rpc] Fix pruneheight help description in getblockchaininfo#11366
Closed
esotericnonsense wants to merge 1 commit intobitcoin:masterfrom
Closed
[rpc] Fix pruneheight help description in getblockchaininfo#11366esotericnonsense wants to merge 1 commit intobitcoin:masterfrom
esotericnonsense wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
utACK 9da936232743a2235dade998be7f01ce0cf1b709. Clarity is good. |
Contributor
|
utACK 9da936232743a2235dade998be7f01ce0cf1b709 Also consider in this PR moving the |
promag
reviewed
Sep 20, 2017
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Nit, I would reword commit and PR to something along [rpc] Fix pruneheight help description in getblockchaininfo.
Otherwise utACK 9da9362.
src/rpc/blockchain.cpp
Outdated
Contributor
There was a problem hiding this comment.
Update to (only present if pruning is enabled). See this example for reference.
esotericnonsense
force-pushed
the
2017-09-getblockchaininfo-docs
branch
from
9da9362 to
887dcc4
Compare
esotericnonsense
changed the title
Contributor
Author
|
Done and done, tested latest commit, appears in correct order. |
promag
reviewed
Sep 20, 2017
| obj.push_back(Pair("verificationprogress", GuessVerificationProgress(Params().TxData(), chainActive.Tip()))); | ||
| obj.push_back(Pair("chainwork", chainActive.Tip()->nChainWork.GetHex())); | ||
| obj.push_back(Pair("pruned", fPruneMode)); | ||
| if (fPruneMode) |
Contributor
There was a problem hiding this comment.
Since this is touched, update as per developer notes? { in this line.
| if (fPruneMode) | ||
| { | ||
| CBlockIndex *block = chainActive.Tip(); | ||
| while (block && block->pprev && (block->pprev->nStatus & BLOCK_HAVE_DATA)) |
Contributor
There was a problem hiding this comment.
Remove first condition block and add assert(block); above.
Contributor
Author
|
Suggest merging this with #11367 to avoid PR dependencies? |
Contributor
Author
|
Changes are now included in #11367. |
laanwj
added a commit
that referenced
this pull request
Sep 25, 2017
f6ffb14 [test] Add getblockchaininfo functional test (João Barbosa) fd8f45f [test] Add restart_node to BitcoinTestFramework (João Barbosa) Pull request description: Adds functional test for `getblockchaininfo`. Also deals with the fact that `pruneheight` is only in the response when pruning is enabled (related to #11366). Tree-SHA512: 56cdec0921f572874f2fdded0990d1722d1435c3ff9979e6bff1afdccdca6f8b214dbe8d7490cdac07b5758909db085132d14340de2cce943241f7ebde7e5b6c
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 12, 2020
f6ffb14 [test] Add getblockchaininfo functional test (João Barbosa) fd8f45f [test] Add restart_node to BitcoinTestFramework (João Barbosa) Pull request description: Adds functional test for `getblockchaininfo`. Also deals with the fact that `pruneheight` is only in the response when pruning is enabled (related to bitcoin#11366). Tree-SHA512: 56cdec0921f572874f2fdded0990d1722d1435c3ff9979e6bff1afdccdca6f8b214dbe8d7490cdac07b5758909db085132d14340de2cce943241f7ebde7e5b6c
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 26, 2021
f6ffb14 [test] Add getblockchaininfo functional test (João Barbosa) fd8f45f [test] Add restart_node to BitcoinTestFramework (João Barbosa) Pull request description: Adds functional test for `getblockchaininfo`. Also deals with the fact that `pruneheight` is only in the response when pruning is enabled (related to bitcoin#11366). Tree-SHA512: 56cdec0921f572874f2fdded0990d1722d1435c3ff9979e6bff1afdccdca6f8b214dbe8d7490cdac07b5758909db085132d14340de2cce943241f7ebde7e5b6c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit nitpicky, but the field isn't included in the JSON at all unless fPruneMode is set.
Alternatively we could return 0 (and remove 'pruned', which would then be pointless, but someone might be relying on that).