Conversation
|
Cool! Thanks for being persistent. Two comments: The appropriate copyright notice should be added to uiproject.fbp and uibase.cpp; I think building the next release with UpNP support compiled in would be a good idea. Having both -noupnp and -upnp options (and tri-state USE_UPNP) is confusing and will cause problems if bitcoin.conf files are copied around. I'd suggest something like (assuming we want upnp on by default for Windows): |
|
Didn't realize Luke added -upnp in his commit, sorry. The original intention was to have USE_UPNP as a compile option as to whether or not one would compile with UPnP or not and a single -noupnp where UPnP defaults to on. |
|
Please start a discussion on the forums about whether or not UpNP should be on or off by default; I think you will find strong feelings that it should be off by default among Linux folks. |
|
Forum thread here: http://www.bitcoin.org/smf/index.php?topic=4392.0 |
|
Consensus seems to be "off by default" |
|
That's the interesting thing about UPnP, for an individual, having UPnP on by default is bad - potential security problems down the line, increased traffic, etc. For the network as a whole, having UPnP on by default is good as it creates more nodes which accept incoming connections ie good for network diversity in the long run. (maybe even increased MAX_OUTBOUND_CONNECTIONS in the future) |
Fix the probability calculation of the minting tab and listminting RPC
b0210a9 Merge pull request bitcoin#135 ee3eb4b Fix a memory leak and add a number of small tests. 4d879a3 Merge pull request bitcoin#134 d5e8362 Merge pull request #127 7b92cf6 Merge pull request #132 0bf70a5 Merge pull request bitcoin#133 29ae131 Make scalar_add_bit test's overflow detection exact 9048def Avoid undefined shift behaviour efb7d4b Use constant-time conditional moves instead of byte slicing d220062 Merge pull request #131 82f9254 Fix typo 601ca04 Merge pull request #129 35399e0 Bugfix: b is restricted, not r c35ff1e Convert lambda splitter to pure scalar code. cc604e9 Avoid division when decomposing scalars ff8746d Add secp256k1_scalar_mul_shift_var bd313f7 Merge pull request #119 276f987 Merge pull request #124 25d125e Merge pull request #126 24b3c65 Add a test case for ECDSA recomputing infinity 32600e5 Add a test for r >= order signature handling 4d4eeea Make secp256k1_fe_mul_inner use the r != property be82e92 Require that r and b are different for field multiplication. 597128d Make num optional 659b554 Make constant initializers independent from num 0af5b47 Merge pull request #120 e2e8a36 Merge pull request #117 c76be9e Remove unused num functions 4285a98 Move lambda-splitting code to scalar. f24041d Switch all EC/ECDSA logic from num to scalar 6794be6 Add scalar splitting functions d1502eb Add secp256k1_scalar_inverse_var which delegates to GMP b5c9ee7 Make test_point_times_order test meaningful again 0b73059 Switch wnaf splitting from num-based to scalar-based 1e6c77c Generalize secp256k1_scalar_get_bits 5213207 Add secp256k1_scalar_add_bit 3c0ae43 Merge pull request #122 6e05287 Do signature recovery/verification with 4 possible recid case e3d692f Explain why no y=0 check is necessary for doubling f7dc1c6 Optimize doubling: secp256k1 has no y=0 point 666d3b5 Merge pull request #121 2a54f9b Correct typo in comment 9d64145 Merge pull request #114 99f0728 Fix secp256k1_num_set_bin handling of 0 d907ebc Add bounds checking to field element setters bb2cd94 Merge pull request #116 665775b Don't split the g factor when not using endomorphism 9431d6b Merge pull request #115 e2274c5 build: osx: attempt to work with homebrew keg-only packages git-subtree-dir: src/secp256k1 git-subtree-split: b0210a9
a3619e2 Fix OSX icon & installer background (zathras-crypto)
Fix PoS diff retarget
bump version to 0.14.4.0
Adjusted testnet zerocoin block and applied 1.4.2 version
3 participants
Finally a seemingly proper patch for UPnP Port Mapping.
Note that this one still does not have proper support in the makefiles for anything but UNIX.